Skip to content

Add regression test for memory leaks in string tensors #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Add regression test for memory leaks in string tensors #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions tensorflow-core/tensorflow-core-api/src/test/java/org/tensorflow/types/TStringTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.nio.charset.StandardCharsets;
import org.bytedeco.javacpp.Pointer;
import org.junit.jupiter.api.Test;
import org.tensorflow.ndarray.NdArray;
import org.tensorflow.ndarray.NdArrays;
Expand Down Expand Up @@ -103,5 +105,30 @@ public void initializingTensorWithRawBytes() {
}
}

@Test
public void testNoLeaks() throws Exception {
System.gc();
Thread.sleep(100);

for (int i = 0; i < 1000; i++) {
TString.scalarOf(A_LARGE_STRING).close();
}

System.gc();
Thread.sleep(100);
long bytesBefore = Pointer.physicalBytes();

for (int i = 0; i < 1000; i++) {
TString.scalarOf(A_LARGE_STRING).close();
}

System.gc();
Thread.sleep(100);
long bytesAfter = Pointer.physicalBytes();

assertTrue(Math.abs(bytesAfter - bytesBefore) < 10_000_000);
}

private static final String A_LARGE_STRING = new String(new byte[1_000_000]);
private static final String BABY_CHICK = "\uD83D\uDC25";
}