From f7809dbb85a1571fa9d1ae82377fa59202ab4d4b Mon Sep 17 00:00:00 2001 From: Erez Louidor Date: Fri, 22 Feb 2019 13:31:24 -0800 Subject: [PATCH 1/2] Enabled hparams plugin --- tensorboard/BUILD | 13 +++++++------ tensorboard/components/tf_tensorboard/BUILD | 1 + .../components/tf_tensorboard/default-plugins.html | 1 + tensorboard/default.py | 4 +++- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/tensorboard/BUILD b/tensorboard/BUILD index d966d6b29a..a87051a869 100644 --- a/tensorboard/BUILD +++ b/tensorboard/BUILD @@ -91,8 +91,8 @@ py_test( deps = [ ":manager", ":version", - "//tensorboard/util:tb_logging", "//tensorboard:expect_tensorflow_installed", + "//tensorboard/util:tb_logging", "@org_pythonhosted_six", ], ) @@ -101,11 +101,14 @@ py_test( name = "manager_e2e_test", size = "large", # spawns subprocesses, sleeps, makes requests to localhost timeout = "moderate", + srcs = ["manager_e2e_test.py"], + data = [ + ":tensorboard", + ], # On Python 2, this test fails about 0.5% of the time when run with # high parallelism; TensorBoard subprocess time out instead of # launching successfully. flaky = True, - srcs = ["manager_e2e_test.py"], srcs_version = "PY2AND3", visibility = ["//tensorboard:internal"], deps = [ @@ -113,9 +116,6 @@ py_test( "//tensorboard:expect_tensorflow_installed", "@org_pythonhosted_six", ], - data = [ - ":tensorboard", - ], ) py_library( @@ -175,6 +175,7 @@ py_library( "//tensorboard/plugins/distribution:distributions_plugin", "//tensorboard/plugins/graph:graphs_plugin", "//tensorboard/plugins/histogram:histograms_plugin", + "//tensorboard/plugins/hparams:hparams_plugin", "//tensorboard/plugins/image:images_plugin", "//tensorboard/plugins/interactive_inference:interactive_inference_plugin", "//tensorboard/plugins/pr_curve:pr_curves_plugin", @@ -430,9 +431,9 @@ py_library( py_test( name = "lazy_test", + size = "small", srcs = ["lazy_test.py"], srcs_version = "PY2AND3", - size = "small", deps = [ ":lazy", "@org_pythonhosted_six", diff --git a/tensorboard/components/tf_tensorboard/BUILD b/tensorboard/components/tf_tensorboard/BUILD index 7ab17c9c85..440e7d8b26 100644 --- a/tensorboard/components/tf_tensorboard/BUILD +++ b/tensorboard/components/tf_tensorboard/BUILD @@ -59,6 +59,7 @@ tf_web_library( "//tensorboard/plugins/distribution/tf_distribution_dashboard", "//tensorboard/plugins/graph/tf_graph_dashboard", "//tensorboard/plugins/histogram/tf_histogram_dashboard", + "//tensorboard/plugins/hparams/tf_hparams_dashboard", "//tensorboard/plugins/image/tf_image_dashboard", "//tensorboard/plugins/interactive_inference/tf_interactive_inference_dashboard", "//tensorboard/plugins/pr_curve/tf_pr_curve_dashboard", diff --git a/tensorboard/components/tf_tensorboard/default-plugins.html b/tensorboard/components/tf_tensorboard/default-plugins.html index fb2d42f1dd..607ce7f26b 100644 --- a/tensorboard/components/tf_tensorboard/default-plugins.html +++ b/tensorboard/components/tf_tensorboard/default-plugins.html @@ -39,3 +39,4 @@ + diff --git a/tensorboard/default.py b/tensorboard/default.py index fccfe4f1f2..90becfb9b9 100644 --- a/tensorboard/default.py +++ b/tensorboard/default.py @@ -36,10 +36,11 @@ from tensorboard.plugins.beholder import beholder_plugin from tensorboard.plugins.core import core_plugin from tensorboard.plugins.custom_scalar import custom_scalars_plugin +from tensorboard.plugins.debugger import debugger_plugin_loader from tensorboard.plugins.distribution import distributions_plugin from tensorboard.plugins.graph import graphs_plugin -from tensorboard.plugins.debugger import debugger_plugin_loader from tensorboard.plugins.histogram import histograms_plugin +from tensorboard.plugins.hparams import hparams_plugin from tensorboard.plugins.image import images_plugin from tensorboard.plugins.interactive_inference import interactive_inference_plugin from tensorboard.plugins.pr_curve import pr_curves_plugin @@ -67,6 +68,7 @@ interactive_inference_plugin.InteractiveInferencePlugin, profile_plugin.ProfilePluginLoader(), debugger_plugin_loader.DebuggerPluginLoader(), + hparams_plugin.HParamsPlugin, ] def get_plugins(): From bc609dec4ccf093c516ea13cf2c57b925c19a758 Mon Sep 17 00:00:00 2001 From: Erez Louidor Date: Fri, 22 Feb 2019 17:19:51 -0800 Subject: [PATCH 2/2] ; --- tensorboard/BUILD | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tensorboard/BUILD b/tensorboard/BUILD index a87051a869..9e41f6c024 100644 --- a/tensorboard/BUILD +++ b/tensorboard/BUILD @@ -91,8 +91,8 @@ py_test( deps = [ ":manager", ":version", - "//tensorboard:expect_tensorflow_installed", "//tensorboard/util:tb_logging", + "//tensorboard:expect_tensorflow_installed", "@org_pythonhosted_six", ], ) @@ -101,14 +101,11 @@ py_test( name = "manager_e2e_test", size = "large", # spawns subprocesses, sleeps, makes requests to localhost timeout = "moderate", - srcs = ["manager_e2e_test.py"], - data = [ - ":tensorboard", - ], # On Python 2, this test fails about 0.5% of the time when run with # high parallelism; TensorBoard subprocess time out instead of # launching successfully. flaky = True, + srcs = ["manager_e2e_test.py"], srcs_version = "PY2AND3", visibility = ["//tensorboard:internal"], deps = [ @@ -116,6 +113,9 @@ py_test( "//tensorboard:expect_tensorflow_installed", "@org_pythonhosted_six", ], + data = [ + ":tensorboard", + ], ) py_library( @@ -431,9 +431,9 @@ py_library( py_test( name = "lazy_test", - size = "small", srcs = ["lazy_test.py"], srcs_version = "PY2AND3", + size = "small", deps = [ ":lazy", "@org_pythonhosted_six",