diff --git a/tensorboard/plugins/core/core_plugin.py b/tensorboard/plugins/core/core_plugin.py index 1a22625b13..9433969505 100644 --- a/tensorboard/plugins/core/core_plugin.py +++ b/tensorboard/plugins/core/core_plugin.py @@ -376,9 +376,12 @@ def define_flags(self, parser): See tensorboard/backend/event_processing/event_file_inspector.py for more info.\ ''') - + + # This flag has a "_tb" suffix to avoid conflicting with an internal flag + # named --version. Note that due to argparse auto-expansion of unambiguous + # flag prefixes, you can still invoke this as `tensorboard --version`. parser.add_argument( - '--version', + '--version_tb', action='store_true', help='Prints the version of Tensorboard') @@ -464,8 +467,8 @@ def define_flags(self, parser): def fix_flags(self, flags): """Fixes standard TensorBoard CLI flags to parser.""" FlagsError = base_plugin.FlagsError - if flags.version: - pass + if flags.version_tb: + pass elif flags.inspect: if flags.logdir and flags.event_file: raise FlagsError( diff --git a/tensorboard/plugins/core/core_plugin_test.py b/tensorboard/plugins/core/core_plugin_test.py index 55f5328c0f..a282b5a638 100644 --- a/tensorboard/plugins/core/core_plugin_test.py +++ b/tensorboard/plugins/core/core_plugin_test.py @@ -47,13 +47,13 @@ class FakeFlags(object): def __init__( self, inspect=False, - version=False, + version_tb=False, logdir='', event_file='', db='', path_prefix=''): self.inspect = inspect - self.version = version + self.version_tb = version_tb self.logdir = logdir self.event_file = event_file self.db = db @@ -81,8 +81,8 @@ def testRoutesProvided(self): def testFlag(self): loader = core_plugin.CorePluginLoader() + loader.fix_flags(FakeFlags(version_tb=True)) loader.fix_flags(FakeFlags(inspect=True, logdir='/tmp')) - loader.fix_flags(FakeFlags(version=True)) loader.fix_flags(FakeFlags(inspect=True, event_file='/tmp/event.out')) loader.fix_flags(FakeFlags(inspect=False, logdir='/tmp')) loader.fix_flags(FakeFlags(inspect=False, db='sqlite:foo')) diff --git a/tensorboard/program.py b/tensorboard/program.py index 65fd78ce33..28ec2b7449 100644 --- a/tensorboard/program.py +++ b/tensorboard/program.py @@ -221,7 +221,7 @@ def main(self, ignored_argv=('',)): event_file = os.path.expanduser(self.flags.event_file) efi.inspect(self.flags.logdir, event_file, self.flags.tag) return 0 - if self.flags.version: + if self.flags.version_tb: print(version.VERSION) return 0 try: