From bca94e03018714aa708e0172f82e150d7fc75e4f Mon Sep 17 00:00:00 2001 From: William Chargin Date: Wed, 11 Dec 2019 14:18:49 -0800 Subject: [PATCH] pylint: remove long-line suppressions on imports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Per suggestion of @nfelt on #2967. We don’t use Pylint for line length, and Google style says that imports are exempt from line length limits, anyway. Generated with: ``` git ls-files -z '*.py' | xargs -0 sed -i -e '/from.*import/s@ *# pylint: disable=line-too-long$@@' ``` Test Plan: Our standard lint still passes: ``` $ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics 0 ``` wchargin-branch: unsuppress-long-imports --- tensorboard/backend/application.py | 6 +++--- tensorboard/backend/application_test.py | 2 +- .../backend/event_processing/plugin_event_multiplexer.py | 2 +- .../event_processing/plugin_event_multiplexer_test.py | 4 ++-- tensorboard/plugins/audio/audio_plugin_test.py | 2 +- tensorboard/plugins/core/core_plugin_test.py | 2 +- .../plugins/custom_scalar/custom_scalars_plugin_test.py | 2 +- tensorboard/plugins/custom_scalar/summary_test.py | 2 +- tensorboard/plugins/debugger/debugger_plugin_test.py | 2 +- tensorboard/plugins/debugger/debugger_plugin_testlib.py | 2 +- tensorboard/plugins/debugger/events_writer_manager_test.py | 2 +- .../plugins/debugger/interactive_debugger_plugin_test.py | 2 +- .../plugins/distribution/distributions_plugin_test.py | 4 ++-- tensorboard/plugins/graph/graphs_plugin.py | 2 +- tensorboard/plugins/graph/graphs_plugin_test.py | 2 +- tensorboard/plugins/histogram/histograms_plugin_test.py | 4 ++-- tensorboard/plugins/image/images_plugin_test.py | 2 +- .../interactive_inference_plugin_test.py | 2 +- tensorboard/plugins/pr_curve/pr_curves_plugin_test.py | 2 +- tensorboard/plugins/profile/profile_plugin.py | 2 +- tensorboard/plugins/profile/profile_plugin_test.py | 2 +- tensorboard/plugins/projector/projector_plugin_test.py | 2 +- tensorboard/plugins/scalar/scalars_plugin_test.py | 4 ++-- tensorboard/plugins/text/text_plugin_test.py | 2 +- 24 files changed, 30 insertions(+), 30 deletions(-) diff --git a/tensorboard/backend/application.py b/tensorboard/backend/application.py index c69facbcc2..5dd0f132dc 100644 --- a/tensorboard/backend/application.py +++ b/tensorboard/backend/application.py @@ -48,9 +48,9 @@ from tensorboard.backend import path_prefix from tensorboard.backend import security_validator from tensorboard.backend.event_processing import db_import_multiplexer -from tensorboard.backend.event_processing import data_provider as event_data_provider # pylint: disable=line-too-long -from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator # pylint: disable=line-too-long -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import data_provider as event_data_provider +from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.audio import metadata as audio_metadata from tensorboard.plugins.core import core_plugin diff --git a/tensorboard/backend/application_test.py b/tensorboard/backend/application_test.py index e28071dd0d..5d3f7c13e8 100644 --- a/tensorboard/backend/application_test.py +++ b/tensorboard/backend/application_test.py @@ -44,7 +44,7 @@ from tensorboard import plugin_util from tensorboard import test as tb_test from tensorboard.backend import application -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin diff --git a/tensorboard/backend/event_processing/plugin_event_multiplexer.py b/tensorboard/backend/event_processing/plugin_event_multiplexer.py index 63a04d4d15..566ab6f9bb 100644 --- a/tensorboard/backend/event_processing/plugin_event_multiplexer.py +++ b/tensorboard/backend/event_processing/plugin_event_multiplexer.py @@ -25,7 +25,7 @@ from six.moves import queue, xrange # pylint: disable=redefined-builtin from tensorboard.backend.event_processing import directory_watcher -from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator from tensorboard.backend.event_processing import io_wrapper from tensorboard.util import tb_logging diff --git a/tensorboard/backend/event_processing/plugin_event_multiplexer_test.py b/tensorboard/backend/event_processing/plugin_event_multiplexer_test.py index 2b81b32ade..0614ed1895 100644 --- a/tensorboard/backend/event_processing/plugin_event_multiplexer_test.py +++ b/tensorboard/backend/event_processing/plugin_event_multiplexer_test.py @@ -23,8 +23,8 @@ import tensorflow as tf -from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator # pylint: disable=line-too-long -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.util import test_util diff --git a/tensorboard/plugins/audio/audio_plugin_test.py b/tensorboard/plugins/audio/audio_plugin_test.py index 3f8260c260..0672c7bffd 100644 --- a/tensorboard/plugins/audio/audio_plugin_test.py +++ b/tensorboard/plugins/audio/audio_plugin_test.py @@ -32,7 +32,7 @@ from werkzeug import wrappers from tensorboard.backend import application -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.audio import audio_plugin from tensorboard.plugins.audio import summary diff --git a/tensorboard/plugins/core/core_plugin_test.py b/tensorboard/plugins/core/core_plugin_test.py index 7426de88f5..8b928cd5dc 100644 --- a/tensorboard/plugins/core/core_plugin_test.py +++ b/tensorboard/plugins/core/core_plugin_test.py @@ -33,7 +33,7 @@ from werkzeug import wrappers from tensorboard.backend import application -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.compat.proto import graph_pb2 from tensorboard.compat.proto import meta_graph_pb2 from tensorboard.plugins import base_plugin diff --git a/tensorboard/plugins/custom_scalar/custom_scalars_plugin_test.py b/tensorboard/plugins/custom_scalar/custom_scalars_plugin_test.py index bcc3bd3d98..ca2e59664a 100644 --- a/tensorboard/plugins/custom_scalar/custom_scalars_plugin_test.py +++ b/tensorboard/plugins/custom_scalar/custom_scalars_plugin_test.py @@ -25,7 +25,7 @@ import tensorflow as tf from google.protobuf import json_format -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.custom_scalar import custom_scalars_plugin from tensorboard.plugins.custom_scalar import layout_pb2 diff --git a/tensorboard/plugins/custom_scalar/summary_test.py b/tensorboard/plugins/custom_scalar/summary_test.py index 2b665539e8..dbd725bb9e 100644 --- a/tensorboard/plugins/custom_scalar/summary_test.py +++ b/tensorboard/plugins/custom_scalar/summary_test.py @@ -22,7 +22,7 @@ import numpy as np import tensorflow as tf -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins.custom_scalar import layout_pb2 from tensorboard.plugins.custom_scalar import metadata from tensorboard.plugins.custom_scalar import summary diff --git a/tensorboard/plugins/debugger/debugger_plugin_test.py b/tensorboard/plugins/debugger/debugger_plugin_test.py index d515bf6daa..834d769ec6 100644 --- a/tensorboard/plugins/debugger/debugger_plugin_test.py +++ b/tensorboard/plugins/debugger/debugger_plugin_test.py @@ -23,7 +23,7 @@ import tensorflow as tf -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.debugger import debugger_plugin_testlib from tensorboard.plugins.debugger import numerics_alert diff --git a/tensorboard/plugins/debugger/debugger_plugin_testlib.py b/tensorboard/plugins/debugger/debugger_plugin_testlib.py index baf5509779..36d4d0d648 100644 --- a/tensorboard/plugins/debugger/debugger_plugin_testlib.py +++ b/tensorboard/plugins/debugger/debugger_plugin_testlib.py @@ -36,7 +36,7 @@ from google.protobuf import json_format from tensorboard.backend import application -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.debugger import constants from tensorflow.core.debug import debugger_event_metadata_pb2 diff --git a/tensorboard/plugins/debugger/events_writer_manager_test.py b/tensorboard/plugins/debugger/events_writer_manager_test.py index d87aed3d2f..d7b7530cdf 100644 --- a/tensorboard/plugins/debugger/events_writer_manager_test.py +++ b/tensorboard/plugins/debugger/events_writer_manager_test.py @@ -23,7 +23,7 @@ import tensorflow as tf -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.debugger import debugger_plugin_testlib from tensorboard.plugins.debugger import numerics_alert diff --git a/tensorboard/plugins/debugger/interactive_debugger_plugin_test.py b/tensorboard/plugins/debugger/interactive_debugger_plugin_test.py index 3dc3823903..53ba831d84 100644 --- a/tensorboard/plugins/debugger/interactive_debugger_plugin_test.py +++ b/tensorboard/plugins/debugger/interactive_debugger_plugin_test.py @@ -39,7 +39,7 @@ from werkzeug import wrappers # pylint: disable=wrong-import-order from tensorboard.backend import application -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.debugger import interactive_debugger_plugin from tensorboard.util import test_util diff --git a/tensorboard/plugins/distribution/distributions_plugin_test.py b/tensorboard/plugins/distribution/distributions_plugin_test.py index 2cfd4598ea..876ae6b796 100644 --- a/tensorboard/plugins/distribution/distributions_plugin_test.py +++ b/tensorboard/plugins/distribution/distributions_plugin_test.py @@ -26,8 +26,8 @@ import tensorflow as tf from tensorboard import errors -from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator # pylint: disable=line-too-long -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.distribution import compressor from tensorboard.plugins.distribution import distributions_plugin diff --git a/tensorboard/plugins/graph/graphs_plugin.py b/tensorboard/plugins/graph/graphs_plugin.py index 8273969d63..ccbbf6b3b5 100644 --- a/tensorboard/plugins/graph/graphs_plugin.py +++ b/tensorboard/plugins/graph/graphs_plugin.py @@ -25,7 +25,7 @@ from tensorboard import plugin_util from tensorboard.backend import http_util from tensorboard.backend import process_graph -from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator from tensorboard.compat.proto import config_pb2 from tensorboard.compat.proto import graph_pb2 from tensorboard.data import provider diff --git a/tensorboard/plugins/graph/graphs_plugin_test.py b/tensorboard/plugins/graph/graphs_plugin_test.py index 656c701cef..70dbb51f0b 100644 --- a/tensorboard/plugins/graph/graphs_plugin_test.py +++ b/tensorboard/plugins/graph/graphs_plugin_test.py @@ -29,7 +29,7 @@ from google.protobuf import text_format from tensorboard.backend.event_processing import data_provider -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.compat.proto import config_pb2 from tensorboard.plugins import base_plugin from tensorboard.plugins.graph import graphs_plugin diff --git a/tensorboard/plugins/histogram/histograms_plugin_test.py b/tensorboard/plugins/histogram/histograms_plugin_test.py index 7fbb6b167f..818f9d4a88 100644 --- a/tensorboard/plugins/histogram/histograms_plugin_test.py +++ b/tensorboard/plugins/histogram/histograms_plugin_test.py @@ -29,8 +29,8 @@ from tensorboard import errors from tensorboard.backend.event_processing import data_provider -from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator # pylint: disable=line-too-long -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.histogram import histograms_plugin from tensorboard.plugins.histogram import summary diff --git a/tensorboard/plugins/image/images_plugin_test.py b/tensorboard/plugins/image/images_plugin_test.py index 09db36aaa8..4184dc1561 100644 --- a/tensorboard/plugins/image/images_plugin_test.py +++ b/tensorboard/plugins/image/images_plugin_test.py @@ -32,7 +32,7 @@ from werkzeug import wrappers from tensorboard.backend import application -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.image import summary from tensorboard.plugins.image import images_plugin diff --git a/tensorboard/plugins/interactive_inference/interactive_inference_plugin_test.py b/tensorboard/plugins/interactive_inference/interactive_inference_plugin_test.py index 269adb7cb7..88bcc72eee 100644 --- a/tensorboard/plugins/interactive_inference/interactive_inference_plugin_test.py +++ b/tensorboard/plugins/interactive_inference/interactive_inference_plugin_test.py @@ -38,7 +38,7 @@ from werkzeug import wrappers from tensorboard.backend import application -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.interactive_inference.utils import inference_utils from tensorboard.plugins.interactive_inference.utils import platform_utils diff --git a/tensorboard/plugins/pr_curve/pr_curves_plugin_test.py b/tensorboard/plugins/pr_curve/pr_curves_plugin_test.py index 876b4e1843..afe1c9a893 100644 --- a/tensorboard/plugins/pr_curve/pr_curves_plugin_test.py +++ b/tensorboard/plugins/pr_curve/pr_curves_plugin_test.py @@ -26,7 +26,7 @@ import six import tensorflow as tf -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.pr_curve import pr_curve_demo from tensorboard.plugins.pr_curve import pr_curves_plugin diff --git a/tensorboard/plugins/profile/profile_plugin.py b/tensorboard/plugins/profile/profile_plugin.py index 211d5f85c2..cf7bab56eb 100644 --- a/tensorboard/plugins/profile/profile_plugin.py +++ b/tensorboard/plugins/profile/profile_plugin.py @@ -151,7 +151,7 @@ def start_grpc_stub_if_necessary(self): if self.master_tpu_unsecure_channel and self.logdir.startswith('gs://'): if self.stub is None: import grpc - from tensorflow.python.tpu.profiler import profiler_analysis_pb2_grpc # pylint: disable=line-too-long + from tensorflow.python.tpu.profiler import profiler_analysis_pb2_grpc # Workaround the grpc's 4MB message limitation. gigabyte = 1024 * 1024 * 1024 options = [('grpc.max_message_length', gigabyte), diff --git a/tensorboard/plugins/profile/profile_plugin_test.py b/tensorboard/plugins/profile/profile_plugin_test.py index 9a7622181e..ce82b58df2 100644 --- a/tensorboard/plugins/profile/profile_plugin_test.py +++ b/tensorboard/plugins/profile/profile_plugin_test.py @@ -25,7 +25,7 @@ from werkzeug import Request from tensorboard.backend.event_processing import plugin_asset_util -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.profile import profile_plugin from tensorboard.plugins.profile import trace_events_pb2 diff --git a/tensorboard/plugins/projector/projector_plugin_test.py b/tensorboard/plugins/projector/projector_plugin_test.py index 1087ce6066..4907bd6144 100644 --- a/tensorboard/plugins/projector/projector_plugin_test.py +++ b/tensorboard/plugins/projector/projector_plugin_test.py @@ -33,7 +33,7 @@ from google.protobuf import text_format from tensorboard.backend import application -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.compat.proto import event_pb2 from tensorboard.compat.proto import summary_pb2 from tensorboard.compat import tf as tf_compat diff --git a/tensorboard/plugins/scalar/scalars_plugin_test.py b/tensorboard/plugins/scalar/scalars_plugin_test.py index 170cb11671..60840c2b11 100644 --- a/tensorboard/plugins/scalar/scalars_plugin_test.py +++ b/tensorboard/plugins/scalar/scalars_plugin_test.py @@ -32,8 +32,8 @@ from tensorboard import errors from tensorboard.backend import application from tensorboard.backend.event_processing import data_provider -from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator # pylint: disable=line-too-long -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_accumulator as event_accumulator +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.core import core_plugin from tensorboard.plugins.scalar import metadata diff --git a/tensorboard/plugins/text/text_plugin_test.py b/tensorboard/plugins/text/text_plugin_test.py index d7796f13f8..2638618d74 100644 --- a/tensorboard/plugins/text/text_plugin_test.py +++ b/tensorboard/plugins/text/text_plugin_test.py @@ -26,7 +26,7 @@ import tensorflow as tf from tensorboard import plugin_util -from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer # pylint: disable=line-too-long +from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer from tensorboard.plugins import base_plugin from tensorboard.plugins.text import text_plugin from tensorboard.util import test_util