From 623564adfb708a3b243299697d0539a20280d0c5 Mon Sep 17 00:00:00 2001 From: Nick Felt Date: Fri, 15 May 2020 19:00:08 -0700 Subject: [PATCH 1/2] update *_plugin_notf_test target deps to match _plugin_test deps Generated mechanically by the following (note that for graphs, we special case and copy from graphs_plugin_test_lib rather than graphs_plugin_test): buildozer 'copy deps audio_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/audio:audio_plugin_notf_test buildozer 'copy deps custom_scalars_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/custom_scalar:custom_scalars_plugin_notf_test buildozer 'copy deps distributions_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/distribution:distributions_plugin_notf_test buildozer 'copy deps graphs_plugin_test_lib' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/graph:graphs_plugin_notf_test buildozer 'copy deps histograms_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/histogram:histograms_plugin_notf_test buildozer 'copy deps images_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/image:images_plugin_notf_test buildozer 'copy deps pr_curves_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/pr_curve:pr_curves_plugin_notf_test buildozer 'copy deps projector_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/projector:projector_plugin_notf_test buildozer 'copy deps scalars_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/scalar:scalars_plugin_notf_test buildozer 'copy deps text_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/text:text_plugin_notf_test --- tensorboard/plugins/audio/BUILD | 1 + tensorboard/plugins/distribution/BUILD | 1 + tensorboard/plugins/graph/BUILD | 2 ++ tensorboard/plugins/histogram/BUILD | 4 +++- tensorboard/plugins/pr_curve/BUILD | 1 + tensorboard/plugins/projector/BUILD | 1 + tensorboard/plugins/scalar/BUILD | 5 ++++- tensorboard/plugins/text/BUILD | 1 + 8 files changed, 14 insertions(+), 2 deletions(-) diff --git a/tensorboard/plugins/audio/BUILD b/tensorboard/plugins/audio/BUILD index 2a3332a8fa..85aae614c8 100644 --- a/tensorboard/plugins/audio/BUILD +++ b/tensorboard/plugins/audio/BUILD @@ -58,6 +58,7 @@ py_test( "//tensorboard:expect_numpy_installed", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", + "//tensorboard/backend/event_processing:data_provider", "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/compat:no_tensorflow", "//tensorboard/plugins:base_plugin", diff --git a/tensorboard/plugins/distribution/BUILD b/tensorboard/plugins/distribution/BUILD index 57fc1feb24..f67c8f4d46 100644 --- a/tensorboard/plugins/distribution/BUILD +++ b/tensorboard/plugins/distribution/BUILD @@ -54,6 +54,7 @@ py_test( deps = [ ":compressor", ":distributions_plugin", + "//tensorboard:errors", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", "//tensorboard/backend/event_processing:event_multiplexer", diff --git a/tensorboard/plugins/graph/BUILD b/tensorboard/plugins/graph/BUILD index 76a49334f9..dc109d6a7b 100644 --- a/tensorboard/plugins/graph/BUILD +++ b/tensorboard/plugins/graph/BUILD @@ -83,11 +83,13 @@ py_test( ":graphs_plugin", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", + "//tensorboard/backend/event_processing:data_provider", "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/compat:no_tensorflow", "//tensorboard/compat/proto:protos_all_py_pb2", "//tensorboard/plugins:base_plugin", "//tensorboard/util:test_util", + "@com_google_protobuf//:protobuf_python", "@org_pocoo_werkzeug", "@org_pythonhosted_six", ], diff --git a/tensorboard/plugins/histogram/BUILD b/tensorboard/plugins/histogram/BUILD index e83053eca2..421051cd9d 100644 --- a/tensorboard/plugins/histogram/BUILD +++ b/tensorboard/plugins/histogram/BUILD @@ -60,11 +60,13 @@ py_test( deps = [ ":histograms_plugin", ":summary", + "//tensorboard:errors", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", - "//tensorboard/backend/event_processing:event_accumulator", "//tensorboard/backend/event_processing:event_multiplexer", + "//tensorboard/backend/event_processing:tag_types", "//tensorboard/compat:no_tensorflow", + "//tensorboard/data:provider", "//tensorboard/plugins:base_plugin", "//tensorboard/util:test_util", "@org_pocoo_werkzeug", diff --git a/tensorboard/plugins/pr_curve/BUILD b/tensorboard/plugins/pr_curve/BUILD index dd85e2f2dd..539e3d13a6 100644 --- a/tensorboard/plugins/pr_curve/BUILD +++ b/tensorboard/plugins/pr_curve/BUILD @@ -70,6 +70,7 @@ py_test( "//tensorboard:expect_numpy_installed", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", + "//tensorboard/backend/event_processing:data_provider_test", "//tensorboard/compat:no_tensorflow", "//tensorboard/plugins:base_plugin", "@org_pocoo_werkzeug", diff --git a/tensorboard/plugins/projector/BUILD b/tensorboard/plugins/projector/BUILD index 3b617201dc..9847f33407 100644 --- a/tensorboard/plugins/projector/BUILD +++ b/tensorboard/plugins/projector/BUILD @@ -86,6 +86,7 @@ py_test( "//tensorboard/backend:application", "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/compat:no_tensorflow", + "//tensorboard/compat/proto:protos_all_py_pb2", "//tensorboard/plugins:base_plugin", "//tensorboard/util:test_util", "@org_pocoo_werkzeug", diff --git a/tensorboard/plugins/scalar/BUILD b/tensorboard/plugins/scalar/BUILD index 9641d1efb5..a28f1feacc 100644 --- a/tensorboard/plugins/scalar/BUILD +++ b/tensorboard/plugins/scalar/BUILD @@ -57,12 +57,15 @@ py_test( main = "scalars_plugin_test.py", srcs_version = "PY2AND3", deps = [ + ":metadata", ":scalars_plugin", ":summary", + "//tensorboard:errors", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", - "//tensorboard/backend/event_processing:event_accumulator", + "//tensorboard/backend/event_processing:tag_types", "//tensorboard/compat:no_tensorflow", + "//tensorboard/compat/proto:protos_all_py_pb2", "//tensorboard/plugins:base_plugin", "//tensorboard/util:test_util", "@org_pocoo_werkzeug", diff --git a/tensorboard/plugins/text/BUILD b/tensorboard/plugins/text/BUILD index 223f7dc2a3..8b0d01a65c 100644 --- a/tensorboard/plugins/text/BUILD +++ b/tensorboard/plugins/text/BUILD @@ -60,6 +60,7 @@ py_test( "//tensorboard:expect_tensorflow_installed", "//tensorboard:plugin_util", "//tensorboard/backend:application", + "//tensorboard/backend/event_processing:data_provider", "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/compat:no_tensorflow", "//tensorboard/plugins:base_plugin", From 9d574717c98e79917e488c8e42f74025524d8c64 Mon Sep 17 00:00:00 2001 From: Nick Felt Date: Fri, 15 May 2020 19:18:31 -0700 Subject: [PATCH 2/2] add missing deps inherited transitively through application --- tensorboard/plugins/core/BUILD | 1 + tensorboard/plugins/custom_scalar/BUILD | 3 +++ tensorboard/plugins/pr_curve/BUILD | 6 ++++-- tensorboard/plugins/scalar/BUILD | 4 ++++ 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/tensorboard/plugins/core/BUILD b/tensorboard/plugins/core/BUILD index 821387055b..80ca43a4c6 100644 --- a/tensorboard/plugins/core/BUILD +++ b/tensorboard/plugins/core/BUILD @@ -32,6 +32,7 @@ py_test( "//tensorboard/backend:application", "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/compat/proto:protos_all_py_pb2", + "//tensorboard/data:provider", "//tensorboard/plugins:base_plugin", "//tensorboard/util:test_util", "@org_pocoo_werkzeug", diff --git a/tensorboard/plugins/custom_scalar/BUILD b/tensorboard/plugins/custom_scalar/BUILD index bdcb3d637a..73c0d25254 100644 --- a/tensorboard/plugins/custom_scalar/BUILD +++ b/tensorboard/plugins/custom_scalar/BUILD @@ -62,6 +62,7 @@ py_test( "//tensorboard:expect_numpy_installed", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", + "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/util:tensor_util", "//tensorboard/util:test_util", ], @@ -79,6 +80,7 @@ py_test( "//tensorboard:expect_numpy_installed", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", + "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/plugins:base_plugin", "//tensorboard/plugins/scalar:scalars_plugin", "//tensorboard/plugins/scalar:summary", @@ -100,6 +102,7 @@ py_test( "//tensorboard:expect_numpy_installed", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", + "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/compat:no_tensorflow", "//tensorboard/plugins:base_plugin", "//tensorboard/plugins/scalar:scalars_plugin", diff --git a/tensorboard/plugins/pr_curve/BUILD b/tensorboard/plugins/pr_curve/BUILD index 539e3d13a6..7cf7b8b456 100644 --- a/tensorboard/plugins/pr_curve/BUILD +++ b/tensorboard/plugins/pr_curve/BUILD @@ -49,7 +49,8 @@ py_test( "//tensorboard:expect_numpy_installed", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", - "//tensorboard/backend/event_processing:data_provider_test", + "//tensorboard/backend/event_processing:data_provider", + "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/plugins:base_plugin", "@org_pocoo_werkzeug", "@org_pythonhosted_six", @@ -70,7 +71,8 @@ py_test( "//tensorboard:expect_numpy_installed", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", - "//tensorboard/backend/event_processing:data_provider_test", + "//tensorboard/backend/event_processing:data_provider", + "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/compat:no_tensorflow", "//tensorboard/plugins:base_plugin", "@org_pocoo_werkzeug", diff --git a/tensorboard/plugins/scalar/BUILD b/tensorboard/plugins/scalar/BUILD index a28f1feacc..38adf3bc2d 100644 --- a/tensorboard/plugins/scalar/BUILD +++ b/tensorboard/plugins/scalar/BUILD @@ -40,6 +40,8 @@ py_test( "//tensorboard:errors", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", + "//tensorboard/backend/event_processing:data_provider", + "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/backend/event_processing:tag_types", "//tensorboard/compat/proto:protos_all_py_pb2", "//tensorboard/plugins:base_plugin", @@ -63,6 +65,8 @@ py_test( "//tensorboard:errors", "//tensorboard:expect_tensorflow_installed", "//tensorboard/backend:application", + "//tensorboard/backend/event_processing:data_provider", + "//tensorboard/backend/event_processing:event_multiplexer", "//tensorboard/backend/event_processing:tag_types", "//tensorboard/compat:no_tensorflow", "//tensorboard/compat/proto:protos_all_py_pb2",