Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: upgrade to Rust 1.52.0 #4947

Merged
merged 1 commit into from
May 8, 2021
Merged

rust: upgrade to Rust 1.52.0 #4947

merged 1 commit into from
May 8, 2021

Conversation

wchargin
Copy link
Contributor

@wchargin wchargin commented May 8, 2021

Summary:
Rust 1.52 is out! The release notes have the rundown, but I’m excited
in particular for str::split_once and a caching fix for Clippy.

wchargin-branch: rust-v1.52.0

@wchargin
rust: upgrade to Rust 1.52.0
7e9cb90 
Summary:
Rust 1.52 is out! The [release notes] have the rundown, but I’m excited
in particular for [`str::split_once`] and a [caching fix for Clippy].

[release notes]: https://blog.rust-lang.org/2021/05/06/Rust-1.52.0.html
[`str::split_once`]: https://doc.rust-lang.org/std/primitive.str.html#method.split_once
[caching fix for Clippy]: rust-lang/rust-clippy#4612

wchargin-branch: rust-v1.52.0
wchargin-source: b4be6db4e642e3c2bbf34d476556901cf12c0c60
@wchargin wchargin added type:build/install core:rustboard //tensorboard/data/server/... labels May 8, 2021
@google-cla google-cla bot added the cla: yes label May 8, 2021
@wchargin wchargin requested a review from stephanwlee May 8, 2021 04:57
stephanwlee
stephanwlee approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@stephanwlee stephanwlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool; specifically, why are you so excited about split_once? :)

@wchargin
Copy link
Contributor Author

wchargin commented May 8, 2021

Both s.split_once("/") and s.splitn(2, "/") let you achieve the same
thing, but splitn returns an iterator whose length is statically
unknown, whereas split_once returns an Option<(&str, &str)>.
Basically, it means that we can write #4950 for slightly nicer code.

It’s just a little thing, but nice nonetheless.

@wchargin wchargin merged commit 8fc01ed into master May 8, 2021
@wchargin wchargin deleted the wchargin-rust-v1.52.0 branch May 8, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanwlee stephanwlee stephanwlee approved these changes

Assignees
No one assigned
Labels
cla: yes core:rustboard //tensorboard/data/server/... type:build/install
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wchargin @stephanwlee