From 5ca9fe1b39b7fdc9e7f78a9c1a60a5ecc55f22f3 Mon Sep 17 00:00:00 2001 From: Brian Dubois Date: Tue, 22 Nov 2022 16:31:21 -0500 Subject: [PATCH 1/2] Fix standalone vz_projector server. --- tensorboard/defs/web.bzl | 2 +- .../plugins/projector/tf_projector_plugin/BUILD | 4 ++-- tensorboard/plugins/projector/vz_projector/BUILD | 14 ++------------ .../{standalone_lib.html => standalone.html} | 2 +- 4 files changed, 6 insertions(+), 16 deletions(-) rename tensorboard/plugins/projector/vz_projector/{standalone_lib.html => standalone.html} (100%) diff --git a/tensorboard/defs/web.bzl b/tensorboard/defs/web.bzl index 16f648235e..88819a716e 100644 --- a/tensorboard/defs/web.bzl +++ b/tensorboard/defs/web.bzl @@ -99,7 +99,7 @@ def _tf_web_library(ctx): ) params = struct( label=str(ctx.label), - bind="localhost:0", + bind="localhost:6006", manifest=[long_path(ctx, man) for man in devserver_manifests.to_list()], external_asset=[struct(webpath=k, path=v) for k, v in ctx.attr.external_assets.items()]) diff --git a/tensorboard/plugins/projector/tf_projector_plugin/BUILD b/tensorboard/plugins/projector/tf_projector_plugin/BUILD index 120a724923..d7069dcca2 100644 --- a/tensorboard/plugins/projector/tf_projector_plugin/BUILD +++ b/tensorboard/plugins/projector/tf_projector_plugin/BUILD @@ -22,7 +22,7 @@ tb_combine_html( output_path = "/tf-projector/projector_binary.html", deps = [ ":tf_projector_plugin", - "//tensorboard/plugins/projector/vz_projector:standalone_lib", + "//tensorboard/plugins/projector/vz_projector:standalone", ], ) @@ -34,6 +34,6 @@ tf_web_library( path = "/tf-projector", deps = [ "//tensorboard/components/tf_imports:roboto", - "//tensorboard/plugins/projector/vz_projector:standalone_lib", + "//tensorboard/plugins/projector/vz_projector:standalone", ], ) diff --git a/tensorboard/plugins/projector/vz_projector/BUILD b/tensorboard/plugins/projector/vz_projector/BUILD index 096724f29f..51a9ac355e 100644 --- a/tensorboard/plugins/projector/vz_projector/BUILD +++ b/tensorboard/plugins/projector/vz_projector/BUILD @@ -112,9 +112,9 @@ genrule( ) tf_web_library( - name = "standalone_lib", + name = "standalone", srcs = [ - "standalone_lib.html", + "standalone.html", "standalone_projector_config.json", ":standalone_bundle.js", ], @@ -124,16 +124,6 @@ tf_web_library( ], ) -tb_combine_html( - name = "standalone", - input_path = "/standalone_lib.html", - js_path = "/standalone.js", - output_path = "/standalone.html", - deps = [ - ":standalone_lib", - ], -) - ################# Test ################## tf_ts_library( diff --git a/tensorboard/plugins/projector/vz_projector/standalone_lib.html b/tensorboard/plugins/projector/vz_projector/standalone.html similarity index 100% rename from tensorboard/plugins/projector/vz_projector/standalone_lib.html rename to tensorboard/plugins/projector/vz_projector/standalone.html index 471e3bda08..644b650de8 100644 --- a/tensorboard/plugins/projector/vz_projector/standalone_lib.html +++ b/tensorboard/plugins/projector/vz_projector/standalone.html @@ -31,7 +31,6 @@ - Date: Tue, 22 Nov 2022 16:54:16 -0500 Subject: [PATCH 2/2] Fix BUILD lint. --- tensorboard/plugins/projector/vz_projector/BUILD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tensorboard/plugins/projector/vz_projector/BUILD b/tensorboard/plugins/projector/vz_projector/BUILD index 51a9ac355e..7d9777cb09 100644 --- a/tensorboard/plugins/projector/vz_projector/BUILD +++ b/tensorboard/plugins/projector/vz_projector/BUILD @@ -1,5 +1,5 @@ load("//tensorboard/defs:defs.bzl", "tf_js_binary", "tf_ng_web_test_suite", "tf_ts_library") -load("//tensorboard/defs:web.bzl", "tb_combine_html", "tf_web_library") +load("//tensorboard/defs:web.bzl", "tf_web_library") package(default_visibility = ["//tensorboard/plugins/projector:__subpackages__"])