From d4a997949c66e8b535db40aa569d5848ad1ab809 Mon Sep 17 00:00:00 2001 From: jameshollyer Date: Thu, 4 May 2023 19:30:15 +0000 Subject: [PATCH 1/2] Temporarily make new ColumnHeader properties optional for sync --- .../webapp/metrics/views/card_renderer/scalar_card_types.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tensorboard/webapp/metrics/views/card_renderer/scalar_card_types.ts b/tensorboard/webapp/metrics/views/card_renderer/scalar_card_types.ts index 7ac0ebeb43..74c15861e4 100644 --- a/tensorboard/webapp/metrics/views/card_renderer/scalar_card_types.ts +++ b/tensorboard/webapp/metrics/views/card_renderer/scalar_card_types.ts @@ -100,8 +100,8 @@ export enum ColumnHeaderType { export interface ColumnHeader { type: ColumnHeaderType; - name: string; - displayName: string; + name?: string; // TODO: make required after internal changes are make + displayName?: string; // TODO: make required after internal changes are make enabled: boolean; } From 2191b280afab3b2c7503cc811e172d89ee53b6f6 Mon Sep 17 00:00:00 2001 From: jameshollyer Date: Thu, 4 May 2023 22:12:48 +0000 Subject: [PATCH 2/2] add name to todo --- .../webapp/metrics/views/card_renderer/scalar_card_types.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tensorboard/webapp/metrics/views/card_renderer/scalar_card_types.ts b/tensorboard/webapp/metrics/views/card_renderer/scalar_card_types.ts index 74c15861e4..7bb005ee63 100644 --- a/tensorboard/webapp/metrics/views/card_renderer/scalar_card_types.ts +++ b/tensorboard/webapp/metrics/views/card_renderer/scalar_card_types.ts @@ -100,8 +100,8 @@ export enum ColumnHeaderType { export interface ColumnHeader { type: ColumnHeaderType; - name?: string; // TODO: make required after internal changes are make - displayName?: string; // TODO: make required after internal changes are make + name?: string; // TODO(jameshollyer): make required after internal changes are made + displayName?: string; // TODO(jameshollyer): make required after internal changes are made enabled: boolean; }