From f5d73d75c8d034af9b46908d58b1bd13e0b07635 Mon Sep 17 00:00:00 2001 From: Adrian RC Date: Fri, 19 Apr 2024 05:32:28 +0000 Subject: [PATCH 1/3] Preserve white space in text plugin. --- tensorboard/components/tf_markdown_view/tf-markdown-view.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tensorboard/components/tf_markdown_view/tf-markdown-view.ts b/tensorboard/components/tf_markdown_view/tf-markdown-view.ts index 522f373659..e13a72907f 100644 --- a/tensorboard/components/tf_markdown_view/tf-markdown-view.ts +++ b/tensorboard/components/tf_markdown_view/tf-markdown-view.ts @@ -46,6 +46,9 @@ class TfMarkdownView extends LegacyElementMixin(PolymerElement) { #markdown > p:last-child { margin-bottom: 0.3em; } + #markdown p { + white-space: pre; + } /* Pleasant styles for Markdown tables. */ #markdown table { From 22da3729aa2f65d2780b65d9ce73090704e84af2 Mon Sep 17 00:00:00 2001 From: Adrian RC Date: Fri, 19 Apr 2024 17:59:58 +0000 Subject: [PATCH 2/3] Update white-space CSS property to use break-spaces instead, to allow text wrapping. --- tensorboard/components/tf_markdown_view/tf-markdown-view.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tensorboard/components/tf_markdown_view/tf-markdown-view.ts b/tensorboard/components/tf_markdown_view/tf-markdown-view.ts index e13a72907f..0616ff3b2d 100644 --- a/tensorboard/components/tf_markdown_view/tf-markdown-view.ts +++ b/tensorboard/components/tf_markdown_view/tf-markdown-view.ts @@ -47,7 +47,7 @@ class TfMarkdownView extends LegacyElementMixin(PolymerElement) { margin-bottom: 0.3em; } #markdown p { - white-space: pre; + white-space: break-spaces; } /* Pleasant styles for Markdown tables. */ From 5814883848f8ed5d61f0c583b437ee56be8aeddb Mon Sep 17 00:00:00 2001 From: Adrian RC Date: Fri, 19 Apr 2024 18:18:44 +0000 Subject: [PATCH 3/3] Adds comment for why we use the white-space property. --- tensorboard/components/tf_markdown_view/tf-markdown-view.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tensorboard/components/tf_markdown_view/tf-markdown-view.ts b/tensorboard/components/tf_markdown_view/tf-markdown-view.ts index 0616ff3b2d..be3ce24596 100644 --- a/tensorboard/components/tf_markdown_view/tf-markdown-view.ts +++ b/tensorboard/components/tf_markdown_view/tf-markdown-view.ts @@ -47,6 +47,9 @@ class TfMarkdownView extends LegacyElementMixin(PolymerElement) { margin-bottom: 0.3em; } #markdown p { + /* Some users include multiple spaces and would like them preserved in + * the text visualization in TB. Googlers, see b/335770352. + */ white-space: break-spaces; }