diff --git a/tensorboard/components/tf_backend/backend.ts b/tensorboard/components/tf_backend/backend.ts index 6806d68e2d..ccb664762d 100644 --- a/tensorboard/components/tf_backend/backend.ts +++ b/tensorboard/components/tf_backend/backend.ts @@ -12,10 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ==============================================================================*/ - -import {compareTagNames} from '../vz-sorting/sorting.js'; -import {RequestManager} from './requestManager.js'; -import {getRouter} from './router.js'; +namespace tf_backend { export type RunToTag = { [run: string]: string[]; @@ -44,13 +41,13 @@ export type DebuggerNumericsAlertReportResponse = DebuggerNumericsAlertReport[]; export const TYPES = []; /** Given a RunToTag, return sorted array of all runs */ -export function getRuns(r: RunToTag): string[] { - return _.keys(r).sort(compareTagNames); +export function getRunsNamed(r: RunToTag): string[] { + return _.keys(r).sort(vz_sorting.compareTagNames); } /** Given a RunToTag, return array of all tags (sorted + dedup'd) */ export function getTags(r: RunToTag): string[] { - return _.union.apply(null, _.values(r)).sort(compareTagNames); + return _.union.apply(null, _.values(r)).sort(vz_sorting.compareTagNames); } /** @@ -61,7 +58,7 @@ export function getTags(r: RunToTag): string[] { export function filterTags(r: RunToTag, runs: string[]): string[] { let result = []; runs.forEach((x) => result = result.concat(r[x])); - return _.uniq(result).sort(compareTagNames); + return _.uniq(result).sort(vz_sorting.compareTagNames); } function timeToDate(x: number): Date { @@ -91,9 +88,10 @@ function detupler(xform: (x: T) => G): (t: TupleData) => Datum & G { }; }; - /** * The following interface (TupleData) describes how the data is sent * over from the backend. */ type TupleData = [number, number, T]; // wall_time, step + +} // namespace tf_backend diff --git a/tensorboard/components/tf_backend/canceller.ts b/tensorboard/components/tf_backend/canceller.ts index a196f82258..1ea3b1010c 100644 --- a/tensorboard/components/tf_backend/canceller.ts +++ b/tensorboard/components/tf_backend/canceller.ts @@ -12,6 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ==============================================================================*/ +namespace tf_backend { /** * A class that allows marking promises as cancelled. @@ -63,3 +64,5 @@ export class Canceller { this.cancellationCount++; } } + +} // namespace tf_backend diff --git a/tensorboard/components/tf_backend/requestManager.ts b/tensorboard/components/tf_backend/requestManager.ts index 0fa198416e..7824791a24 100644 --- a/tensorboard/components/tf_backend/requestManager.ts +++ b/tensorboard/components/tf_backend/requestManager.ts @@ -12,11 +12,13 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ==============================================================================*/ +namespace tf_backend { interface ResolveReject { resolve: Function; reject: Function; } + /** * Manages many fetch requests. Launches up to nSimultaneousRequests * simultaneously, and maintains a LIFO queue of requests to process when @@ -175,3 +177,5 @@ export class RequestManager { }); } } + +} // namespace tf_backend diff --git a/tensorboard/components/tf_backend/router.ts b/tensorboard/components/tf_backend/router.ts index a913f10a02..2e94323e84 100644 --- a/tensorboard/components/tf_backend/router.ts +++ b/tensorboard/components/tf_backend/router.ts @@ -12,8 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ==============================================================================*/ - -import {addParams} from './urlPathHelpers.js'; +namespace tf_backend { export interface Router { logdir: () => string; @@ -76,3 +75,5 @@ export function setRouter(router: Router): void { } _router = router; } + +} // namespace tf_backend diff --git a/tensorboard/components/tf_backend/runsStore.ts b/tensorboard/components/tf_backend/runsStore.ts index 22bbcfc169..a53a54e50c 100644 --- a/tensorboard/components/tf_backend/runsStore.ts +++ b/tensorboard/components/tf_backend/runsStore.ts @@ -12,9 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ==============================================================================*/ - -import {RequestManager} from './requestManager.js'; -import {getRouter} from './router.js'; +namespace tf_backend { let runs: string[] = []; @@ -66,3 +64,5 @@ export function fetchRuns(): Promise { export function getRuns(): string[] { return runs.slice(); } + +} // namespace tf_backend diff --git a/tensorboard/components/tf_backend/test/BUILD b/tensorboard/components/tf_backend/test/BUILD index ae9df93ea7..989ae6da71 100644 --- a/tensorboard/components/tf_backend/test/BUILD +++ b/tensorboard/components/tf_backend/test/BUILD @@ -22,4 +22,3 @@ ts_web_library( "//tensorboard/components/tf_imports:webcomponentsjs", ], ) - diff --git a/tensorboard/components/tf_backend/test/backendTests.ts b/tensorboard/components/tf_backend/test/backendTests.ts index 19520e2228..d250709f59 100644 --- a/tensorboard/components/tf_backend/test/backendTests.ts +++ b/tensorboard/components/tf_backend/test/backendTests.ts @@ -12,11 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ==============================================================================*/ - -import {filterTags, getRuns, getTags, RunToTag, TYPES} from '../backend.js'; -import {RequestManager} from '../requestManager.js'; -import {createRouter, setRouter} from '../router.js'; -import {addParams} from '../urlPathHelpers.js'; +namespace tf_backend { describe('urlPathHelpers', () => { it('addParams leaves input untouched when there are no parameters', () => { @@ -67,17 +63,19 @@ describe('backend tests', () => { }; const empty1: RunToTag = {}; const empty2: RunToTag = {run1: [], run2: []}; - chai.assert.deepEqual(getRuns(r2t), ['a', 'run1', 'run2']); + chai.assert.deepEqual(getRunsNamed(r2t), ['a', 'run1', 'run2']); chai.assert.deepEqual(getTags(r2t), ['bar', 'foo', 'zod', 'zoink']); chai.assert.deepEqual(filterTags(r2t, ['run1', 'run2']), getTags(r2t)); chai.assert.deepEqual(filterTags(r2t, ['run1']), ['bar', 'foo', 'zod']); chai.assert.deepEqual( filterTags(r2t, ['run2', 'a']), ['foo', 'zod', 'zoink']); - chai.assert.deepEqual(getRuns(empty1), []); + chai.assert.deepEqual(getRunsNamed(empty1), []); chai.assert.deepEqual(getTags(empty1), []); - chai.assert.deepEqual(getRuns(empty2), ['run1', 'run2']); + chai.assert.deepEqual(getRunsNamed(empty2), ['run1', 'run2']); chai.assert.deepEqual(getTags(empty2), []); }); }); + +} // namespace tf_backend diff --git a/tensorboard/components/tf_backend/test/requestManagerTests.ts b/tensorboard/components/tf_backend/test/requestManagerTests.ts index 08407b5af3..acbc67e3aa 100644 --- a/tensorboard/components/tf_backend/test/requestManagerTests.ts +++ b/tensorboard/components/tf_backend/test/requestManagerTests.ts @@ -12,8 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ==============================================================================*/ - -import {RequestManager, RequestNetworkError} from '../requestManager.js'; +namespace tf_backend { interface MockRequest { resolve: Function; @@ -292,3 +291,5 @@ describe('backend', () => { }); }); }); + +} // namespace tf_backend diff --git a/tensorboard/components/tf_backend/urlPathHelpers.ts b/tensorboard/components/tf_backend/urlPathHelpers.ts index ae3be79150..fe2b79e175 100644 --- a/tensorboard/components/tf_backend/urlPathHelpers.ts +++ b/tensorboard/components/tf_backend/urlPathHelpers.ts @@ -12,6 +12,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ==============================================================================*/ +namespace tf_backend { + /** * A query parameter value can either be a string or a list of strings. * A string `"foo"` is encoded as `key=foo`; a list `["foo", "bar"]` is @@ -51,3 +53,5 @@ function _encodeURIComponent(x: string): string { // Replace parentheses for consistency with Python's urllib.urlencode. return encodeURIComponent(x).replace(/\(/g, '%28').replace(/\)/g, '%29'); } + +} // namespace tf_backend diff --git a/tensorboard/components/tf_card_heading/BUILD b/tensorboard/components/tf_card_heading/BUILD index 3f5f8f9ea2..b860b1b1a3 100644 --- a/tensorboard/components/tf_card_heading/BUILD +++ b/tensorboard/components/tf_card_heading/BUILD @@ -10,7 +10,7 @@ ts_web_library( "tf-card-heading.html", "tf-card-heading-style.html", "util.html", - "util.js", + "util.ts", ], path = "/tf-card-heading", visibility = ["//visibility:public"], diff --git a/tensorboard/components/tf_card_heading/tf-card-heading.html b/tensorboard/components/tf_card_heading/tf-card-heading.html index a24db4378c..79c2bd2c18 100644 --- a/tensorboard/components/tf_card_heading/tf-card-heading.html +++ b/tensorboard/components/tf_card_heading/tf-card-heading.html @@ -113,8 +113,6 @@ diff --git a/tensorboard/plugins/histogram/tf_histogram_dashboard/tf-histogram-dashboard.html b/tensorboard/plugins/histogram/tf_histogram_dashboard/tf-histogram-dashboard.html index 9838af2ae1..b018d63975 100644 --- a/tensorboard/plugins/histogram/tf_histogram_dashboard/tf-histogram-dashboard.html +++ b/tensorboard/plugins/histogram/tf_histogram_dashboard/tf-histogram-dashboard.html @@ -137,12 +137,6 @@

No histogram data was found.