Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/wandb missing final scores #88

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Fix/wandb missing final scores #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c22ec9
fix: wandb now storing final scores correctly
mediumsizeworkingdog Dec 6, 2024
49f0527
fix: cast scores from tensor.float to primitive float
mediumsizeworkingdog Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions commons/scoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,8 +641,8 @@ def calculate_score(
ground_truth = gt_score[i]

# NOTE: just use ground truth for now
hotkey_to_final_score[r.axon.hotkey] = ground_truth / len(
criteria_types
hotkey_to_final_score[r.axon.hotkey] = float(
ground_truth / len(criteria_types)
)

criteria_to_miner_scores[criteria.type] = Score(
Expand Down
2 changes: 1 addition & 1 deletion neurons/validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,7 +1307,7 @@ async def _log_wandb(
)

score_data = {
"scores_by_hotkey": hotkey_to_score,
"scores_by_hotkey": [hotkey_to_score],
"mean": {
"consensus": mean_weighted_consensus_scores,
"ground_truth": mean_weighted_gt_scores,
Expand Down