Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content_of to get buffer contents quickly #59

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jonathandw743
Copy link

Added traits that allow the user to quickly get the buffer contents for a value. This would be convenient for writing data to GPU buffers.

@jonathandw743 jonathandw743 changed the title Buffercontenttraitonly BufferContentTrait Dec 9, 2023
@jonathandw743 jonathandw743 marked this pull request as draft December 9, 2023 21:36
@jonathandw743 jonathandw743 marked this pull request as ready for review December 9, 2023 21:38
Copy link
Owner

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but the trait will have to be in scope.
What about adding the functions onto the existing buffer types?

ex StorageBuffer::content_of(item: &T) -> Vec<u8>

src/core/buffers.rs Outdated Show resolved Hide resolved
@jonathandw743
Copy link
Author

This looks good but the trait will have to be in scope. What about adding the functions onto the existing buffer types?

ex StorageBuffer::content_of(item: &T) -> Vec<u8>

yeah ok

@jonathandw743 jonathandw743 marked this pull request as draft December 11, 2024 20:56
@jonathandw743 jonathandw743 changed the title BufferContentTrait content_of to get buffer contents quickly Dec 11, 2024
@jonathandw743
Copy link
Author

back after a year lol, i have no idea why CI is failing. it doesn't even look like its to do with this change

@jonathandw743 jonathandw743 marked this pull request as ready for review December 11, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants