-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade erlang to 24.1.2 #7738
upgrade erlang to 24.1.2 #7738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably you need to link against libgcc
or compiler-rt
. See https://stackoverflow.com/questions/57756695/android-arm-undefined-reference-to-aeabi-uidiv-clang
Also note that libgcc has been removed from NDK r23
@thunder-coding I have no idea about compiler-rt, Could you please give some example about use it? |
OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably you need to apply this diff asmjit/asmjit@8ee4c76#diff-1b3ebb13c9d717b8e504ce8b4a23127f51a1ea675589d1863ac00a6fc83c36f0
Note: The path needs to be changed. asmjit is in stored in erts/emulator/asmjit
in the Erlang source
done. |
Just a final review: Can you squash your commits and rebase against master instead of merging the master branch. The CI doesn't like merge commits and there have been problems due to merge commits earlier. I am ready to merge this then |
19b5f90
to
7fe735e
Compare
commits squashed. |
0e5417e
to
1a5fda2
Compare
1a5fda2
to
6832de4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.