Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added weighted-forward rules for HTTP #236

Merged

Conversation

gbloquel
Copy link
Contributor

@gbloquel gbloquel commented Feb 8, 2022

Description

This PR add 'weighted-forward' dynamic action block to use with the http_tcp_listener_rule for multiple weighted target_group.
It is very close to #224 but manage the http.

Motivation and Context

This adds a dynamic action block for a "weighted-forward" action_rule.type for the http_tcp_listener_rules . It allows us to create a listener rule like:

{
  http_tcp_listener_index = 0
  priority                = 30

  actions = [
    {
      type = "weighted-forward"
      target_groups = [
        {
          target_group_index = 1
          weight             = 1
        },
        {
          target_group_index = 0
          weight             = 0
        }
      ]
    }
  ]

  conditions = [{}]
}

Breaking Changes

No breaking changes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

I created the resources and visually verified the correct rules made it onto the load balancer.

+ forward {
  + stickiness {
    + duration = 0
    + enabled  = false
  }
  
  + target_group {
    + arn    = "arn:aws:elasticloadbalancing:eu-west-1:../21b716c2bd84930d"
    + weight = 1
  }
  + target_group {
    + arn    = "arn:aws:elasticloadbalancing:eu-west-1:../6c33705a9ab0897a"
    + weight = 2
  }
}

@gbloquel gbloquel changed the title Http weight forwarded rules feat: Http weight forwarded rules Feb 8, 2022
@gbloquel
Copy link
Contributor Author

gbloquel commented Feb 8, 2022

Also complete fixes #211

@gbloquel
Copy link
Contributor Author

Hello @antonbabenko
Could you review my PR ?
Regards,

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 21, 2022
@gbloquel gbloquel force-pushed the http_weight_forwarded_rules branch from 96fe502 to 1b97f6b Compare March 21, 2022 06:27
@gbloquel
Copy link
Contributor Author

Hello @antonbabenko
Could you review my PR ?
Regards,

@github-actions github-actions bot removed the stale label Mar 22, 2022
@antonbabenko antonbabenko changed the title feat: Http weight forwarded rules feat: Added weighted-forward rules for HTTP Apr 15, 2022
@antonbabenko antonbabenko merged commit ba77760 into terraform-aws-modules:master Apr 15, 2022
antonbabenko pushed a commit that referenced this pull request Apr 15, 2022
## [6.9.0](v6.8.0...v6.9.0) (2022-04-15)

### Features

* Added `weighted-forward` rules for HTTP ([#236](#236)) ([ba77760](ba77760))
@antonbabenko
Copy link
Member

This PR is included in version 6.9.0 🎉

@antonbabenko
Copy link
Member

Thank you @gbloquel !

Sorry that it took some time for this to be merged.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
@gbloquel gbloquel deleted the http_weight_forwarded_rules branch November 19, 2022 07:36
@gbloquel gbloquel restored the http_weight_forwarded_rules branch November 19, 2022 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants