fix: lifecycle changes for bug 164 #166
Conversation
|
I was gone to propose the same MR ! Thanks ! Just, I think it will be better for retrocompatibility to add a Actually my tags are switching at evry runs... And they are important for automation tasks. |
The reason I put this in was the same my tags changed every run and automation tasks used them, this fixes that. |
|
accidently closed request (sorry) reopening |
|
Couldn't lifecycle be exposed as an optional variable so that everybody could provide input needed? |
|
@tbugfinder This is not possible in Terraform. |
|
So I do appreciate this is a sponsored project but what is the verdict on this? |
|
Is this a sponsored project? :) I didn't know that, but everyone is more than welcome - https://github.com/sponsors/antonbabenko Regarding the verdict on this, the proposed PR is going to break functionality many users rely on so we can't merge it as is. We need to wait for the time when Terraform allows us to use variables in Meanwhile, please use your own fork. |
|
Closing pull request as per maintainer feedback. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Stops the clobbering of volume tags if you have EBS volumes attached with their own tags
Motivation and Context
Fixes a bug triggered by an outstanding terraform issue:
hashicorp/terraform-provider-aws#770
closes #164
Breaking Changes
None
How Has This Been Tested?
Ran in live code from my repository, tags no longer flip-flopped between instance tags and EBS volume tags, resources kept their own tags.