From a2a0a488c66970a055b2b3e0dfb0a1d95ff36ec8 Mon Sep 17 00:00:00 2001
From: Bryant Biggs <bryantbiggs@gmail.com>
Date: Tue, 9 Apr 2024 12:59:30 -0400
Subject: [PATCH] docs: Add examples for open issue questions

---
 .pre-commit-config.yaml  |  4 ++--
 examples/fargate/main.tf | 19 +++++++++++++++----
 2 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 0e30c59..26103a5 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.88.1
+    rev: v1.88.4
     hooks:
       - id: terraform_fmt
       - id: terraform_wrapper_module_for_each
@@ -25,7 +25,7 @@ repos:
           - '--args=--only=terraform_unused_required_providers'
       - id: terraform_validate
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.5.0
+    rev: v4.6.0
     hooks:
       - id: check-merge-conflict
       - id: end-of-file-fixer
diff --git a/examples/fargate/main.tf b/examples/fargate/main.tf
index 247124c..c263e0b 100644
--- a/examples/fargate/main.tf
+++ b/examples/fargate/main.tf
@@ -121,6 +121,12 @@ module "ecs_service" {
         }
       }
 
+      # Not required for fluent-bit, just an example
+      volumes_from = [{
+        sourceContainer = "fluent-bit"
+        readOnly        = false
+      }]
+
       memory_reservation = 100
     }
   }
@@ -179,15 +185,19 @@ module "ecs_task_definition" {
   source = "../../modules/service"
 
   # Service
-  name           = "${local.name}-standalone"
-  cluster_arn    = module.ecs_cluster.arn
-  create_service = false
+  name        = "${local.name}-standalone"
+  cluster_arn = module.ecs_cluster.arn
 
   # Task Definition
   volume = {
     ex-vol = {}
   }
 
+  runtime_platform = {
+    cpu_architecture        = "ARM64"
+    operating_system_family = "LINUX"
+  }
+
   # Container definition(s)
   container_definitions = {
     al2023 = {
@@ -200,7 +210,8 @@ module "ecs_task_definition" {
         }
       ]
 
-      command = ["/usr/bin/cat", "/etc/os-release"]
+      command    = ["echo hello world"]
+      entrypoint = ["/usr/bin/sh", "-c"]
     }
   }