feat: Add domain support
#429
Conversation
|
Waiting hashicorp/terraform-provider-aws#35753 to be released with |
Signed-off-by: Mehmet Gungoren <mehgungoren@gmail.com>
| @@ -0,0 +1,78 @@ | |||
| # PostgreSQL Example | |||
There was a problem hiding this comment.
I don't think we need to show this in an example - adding a directory service resource will take a looooooooooooooooooooong time to test/validate. For this change we can skip the example usage - @antonbabenko what are your thoughts
There was a problem hiding this comment.
Yep, it takes to looooooooooooong time. hashicorp/terraform-provider-aws#35753 (36min)
=== CONT TestAccRDSCluster_domain
--- PASS: TestAccRDSCluster_domain (2167.36s)
There was a problem hiding this comment.
I agree, we don't need to add such a long example. The feature itself adds just 2 new arguments to the module.
There was a problem hiding this comment.
kerberos example removed from PR.
Signed-off-by: Mehmet Gungoren <mehgungoren@gmail.com>
| @@ -0,0 +1,78 @@ | |||
| # PostgreSQL Example | |||
There was a problem hiding this comment.
I agree, we don't need to add such a long example. The feature itself adds just 2 new arguments to the module.
Signed-off-by: Mehmet Gungoren <mehgungoren@gmail.com>
## [9.1.0](v9.0.2...v9.1.0) (2024-02-16) ### Features * Add `domain` support ([#429](#429)) ([29bb9d6](29bb9d6))
|
This PR is included in version 9.1.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add
domainanddomain_iam_role_namesupport toaws_rds_clusterMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request