Move orjson to be an optional dependency #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use it if available for faster parsing but for those less keen on using a multi stage docker build and ensuring they have the correct shared library dependencies (particularly challenging if building off an alpine container that doesn't use a distribution build) they can avoid the extra_requirement.
eerkunt
reviewed
Jul 1, 2021
Comment on lines
+62
to
+64
| "faster_parsing": ["orjson"], | ||
| } |
There was a problem hiding this comment.
Oh didn't even know we could use it like this!
eerkunt
requested changes
Jul 1, 2021
I've added a few notes to the documentation - let me know if I'm on the right track with the kind of update to the documentation you are thinking or if you were thinking of something else? |
eerkunt
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it if available for faster parsing but for those less keen on using
a multi stage docker build and ensuring they have the correct shared
library dependencies (particularly challenging if building off an alpine
container that doesn't use a distribution build) they can avoid the
extra_requirement.