Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of vpc_zone_identifier for autoscaling groups in EC2 classic #1191

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Fix handling of vpc_zone_identifier for autoscaling groups in EC2 classic #1191

merged 1 commit into from
Jul 20, 2017

Conversation

joshuaspence
Copy link
Contributor

Fixes hashicorp/terraform#6417.

> make testacc TESTARGS='-run=TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (90.85s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws   90.878s

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thanks for the acceptance test 👍 This LGTM.

@radeksimko
Copy link
Member

btw. I think this isn't just EC2 Classic specific problem, it may affect VPC accounts too. AFAIK the ASG will just use subnets from the default VPC if none are defined.

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jul 20, 2017
@radeksimko radeksimko merged commit deb3eef into hashicorp:master Jul 20, 2017
@joshuaspence joshuaspence deleted the classic-vpczoneidentifier branch July 20, 2017 08:15
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPCZoneIdentifier cannot be empty
2 participants