Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_instance: Bump deletion timeout to 20mins #3452

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

radeksimko
Copy link
Member

Similar to #3435

This is to address the following test failures:

=== RUN   TestAccAWSInstance_sourceDestCheck
--- FAIL: TestAccAWSInstance_sourceDestCheck (1416.49s)
    testing.go:573: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: Error applying: 1 error(s) occurred:
        
        * aws_instance.foo (destroy): 1 error(s) occurred:
        
        * aws_instance.foo: Error waiting for instance (i-0fa76ebc595aa2792) to terminate: timeout while waiting for state to become 'terminated' (last state: 'shutting-down', timeout: 10m0s)

=== RUN   TestAccAWSInstancesDataSource_tags
--- FAIL: TestAccAWSInstancesDataSource_tags (760.44s)
    testing.go:573: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: Error applying: 1 error(s) occurred:
        
        * aws_instance.test[3] (destroy): 1 error(s) occurred:
        
        * aws_instance.test.3: Error waiting for instance (i-0aac9db15df3d1648) to terminate: timeout while waiting for state to become 'terminated' (timeout: 10m0s)

@radeksimko radeksimko added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 20, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Feb 20, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radeksimko radeksimko merged commit fd6f713 into master Feb 20, 2018
@radeksimko radeksimko deleted the b-instance-bump-deletion-timeout branch February 20, 2018 13:04
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants