Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set subnet_mapping element attributes to ForceNew #4086

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

mmdriley
Copy link
Contributor

@mmdriley mmdriley commented Apr 6, 2018

The way diffSet in Terraform works on Resource, the ForceNew property
on the Set has no effect unless ForceNew is also set on the resource's
attributes.

Without ForceNew on these attributes, changing subnet_mappings just
silently does nothing.

The way `diffSet` in Terraform works on `Resource`, the `ForceNew` property
on the Set has no effect unless `ForceNew` is also set on the resource's
attributes.

Without `ForceNew` on these attributes, changing `subnet_mappings` just
silently does nothing.
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Apr 6, 2018
@mmdriley
Copy link
Contributor Author

mmdriley commented Apr 6, 2018

Example output without this change:

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ aws_lb.test
      enable_http2:                            "" => "true"
      idle_timeout:                            "" => "60"
      subnet_mapping.2493713080.allocation_id: "" => ""
      subnet_mapping.2493713080.subnet_id:     "" => "subnet-d3d764ab"
      subnet_mapping.3213777275.allocation_id: "" => ""
      subnet_mapping.3213777275.subnet_id:     "subnet-d3d764aa" => ""


Plan: 0 to add, 1 to change, 0 to destroy.

@jen20 jen20 added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Apr 7, 2018
@bflad
Copy link
Contributor

bflad commented Apr 9, 2018

Can you please add an acceptance test to cover the behavior?

@bflad bflad added this to the v1.15.0 milestone Apr 17, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to pull this in as-is -- thanks @mmdriley! 🚀

@bflad bflad merged commit f6b3593 into hashicorp:master Apr 17, 2018
bflad added a commit that referenced this pull request Apr 17, 2018
@bflad
Copy link
Contributor

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants