Add tag group support for codedeploy-deployment-group #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moriyoshi
changed the title
moriyoshi
force-pushed
the
moriyoshi/feature/ec2-tag-set
branch
from
8ec56c9
to
ea431dd
Compare
ghost
added
size/M
bflad
added
enhancement
|
Nice, @moriyoshi! Are you able to add an acceptance test for this as well? |
moriyoshi
force-pushed
the
moriyoshi/feature/ec2-tag-set
branch
from
f8615e5
to
e6ab059
Compare
moriyoshi
force-pushed
the
moriyoshi/feature/ec2-tag-set
branch
from
e6ab059
to
088783c
Compare
|
Thanks for looking into this. Just added an acceptance test. |
bflad
approved these changes
Apr 25, 2018
There was a problem hiding this comment.
Looks great, @moriyoshi, thanks! 🚀
29 tests passed (all tests)
=== RUN TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (79.76s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (81.07s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (81.09s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_disappears
--- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (81.12s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (81.50s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (83.76s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (86.33s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (90.35s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (92.18s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (24.36s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_onPremiseTag
--- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (105.56s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (26.07s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_basic
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (113.05s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (33.41s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (22.52s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (25.26s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (35.45s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_create (36.03s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (35.06s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (123.59s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (132.70s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (135.61s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_basic_tagSet
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (146.66s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (149.19s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (167.74s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (184.98s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (194.32s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (202.60s)
=== RUN TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (195.27s)
bflad
added a commit
that referenced
this pull request
Apr 25, 2018
This was referenced Apr 25, 2018
|
This has been released in version 1.17.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements #2073 (#2930) .