Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Source Route 53 Zone has attribute name_servers #4336

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Data Source Route 53 Zone has attribute name_servers #4336

merged 2 commits into from
Apr 25, 2018

Conversation

genevieve
Copy link
Contributor

Fixes #4334

  • Added name_servers attribute
  • Added destroy step to acceptance test

cwlbraa and others added 2 commits April 24, 2018 16:51
@cwlbraa
data route53 dns zone has name_servers attribute.
7d5cde1 
Fixes hashicorp#4334.

Signed-off-by: Genevieve LEsperance <glesperance@pivotal.io>
@cwlbraa
Add clean-up after acceptance test.
20e1d8e 
Signed-off-by: Connor Braa <connor.braa@gmail.com>
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 24, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service. labels Apr 25, 2018
bflad
bflad approved these changes Apr 25, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @genevieve! Thanks! 🚀

1 test passed (all tests)
=== RUN   TestAccDataSourceAwsRoute53Zone
--- PASS: TestAccDataSourceAwsRoute53Zone (78.71s)

@bflad bflad added this to the v1.17.0 milestone Apr 25, 2018
@bflad
Copy link
Contributor

bflad commented Apr 25, 2018

I will add the attribute to the documentation post-merge 😄

@bflad bflad merged commit 4fef55d into hashicorp:master Apr 25, 2018
@genevieve
Copy link
Contributor Author

Oh sorry I forgot docs, I can make a PR for that!

bflad added a commit that referenced this pull request Apr 25, 2018
@bflad
Update CHANGELOG for #4336
b91792d
@genevieve genevieve mentioned this pull request Apr 25, 2018
Closed
@bflad
Copy link
Contributor

bflad commented May 2, 2018

This has been released in version 1.17.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@saravanan30erd saravanan30erd mentioned this pull request Jun 23, 2018
Closed
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

Data Source Route 53 Zone has attribute name_servers
3 participants
@genevieve @bflad @cwlbraa