4701 aws_service_discovery_private_dns_namespace name length limit

[ahl]

Fixes #4701 aws_service_discovery_private_dns_namespace

Changes proposed in this pull request:

• use a hash of the name if its length exceeds 32 characters

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSServiceDiscoveryPrivateDnsNamespace'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSServiceDiscoveryPrivateDnsNamespace -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSServiceDiscoveryPrivateDnsNamespace_basic
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_basic (21.61s)
=== RUN   TestAccAWSServiceDiscoveryPrivateDnsNamespace_longname
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_longname (20.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.513s

[bflad]

Thanks for submitting this fix @ahl! 🚀

I believe we actually just need to trim the input into resource.PrefixedUniqueId() which I'll double check post-merge and update if it still passes your new acceptance test 😄

2 tests passed (all tests)
=== RUN   TestAccAWSServiceDiscoveryPrivateDnsNamespace_longname
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_longname (10.92s)
=== RUN   TestAccAWSServiceDiscoveryPrivateDnsNamespace_basic
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_basic (13.05s)

[bflad]

We actually do not need to perform any hashing as resource.PrefixedUniqueId() already includes a mutex with a monotonic counter to ensure it is unique even during concurrent operations with the same prefix:

https://github.com/hashicorp/terraform/blob/ad259b2b9569cadd4a24f051e271fa5e669066f2/helper/resource/id.go#L35-L45

We just need to trim the input string 👍

[ahl]

That's a lot simpler. Why even bother with a prefix based on the name if it is irrelevant for uniqueness? Why not use "" or "terraform" or "private_dns_namespace"?

Thanks for merging and cleaning up

[bflad]

This has been released in version 1.22.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!