Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_storagegateway_smb_file_share #5276

Merged
merged 2 commits into from
Aug 3, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 20, 2018

Built on top of #5269
Reference #943

Changes proposed in this pull request:

  • New Resource: aws_storagegateway_smb_file_share

Output from acceptance testing:

11 tests passed (all tests)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (226.03s)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (252.38s)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (263.79s)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (264.86s)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ObjectACL
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (285.56s)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_RequesterPays
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (294.13s)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ReadOnly
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (297.41s)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (422.49s)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (632.34s)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (772.82s)
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ValidUserList
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (862.85s)

@bflad bflad added new-resource Introduces a new resource. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Jul 20, 2018
@bflad bflad requested a review from a team July 20, 2018 17:43
@ghost ghost added the size/XXL Managed by automation to categorize the size of a PR. label Jul 20, 2018
@bflad bflad force-pushed the f-aws_storagegateway_smb_file_share branch from b41ec75 to 57f0dd8 Compare July 27, 2018 19:58
@ghost ghost added the size/XXL Managed by automation to categorize the size of a PR. label Jul 27, 2018
@bflad bflad added this to the v1.31.0 milestone Aug 3, 2018
@bflad bflad merged commit e4dc788 into master Aug 3, 2018
@bflad bflad deleted the f-aws_storagegateway_smb_file_share branch August 3, 2018 15:13
bflad added a commit that referenced this pull request Aug 3, 2018
@bflad
Copy link
Contributor Author

bflad commented Aug 9, 2018

This has been released in version 1.31.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants