Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5811 Enable x-ray tracing in api_gateway #5817

Merged
merged 4 commits into from
Sep 13, 2018

Conversation

saravanan30erd
Copy link
Contributor

@saravanan30erd saravanan30erd commented Sep 9, 2018

Fixes #5811

Changes proposed in this pull request:

  • Change 1
    Added x-ray tracing attribute in api_gateway_stage
  • Change 2
    Added x-ray tracing attribute in api_gateway_deployment
  • Change 3
    Refactored the api_gateway_deployment

Dep PR #5816
Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayStage_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAPIGatewayStage_basic -timeout 120m
=== RUN   TestAccAWSAPIGatewayStage_basic
--- PASS: TestAccAWSAPIGatewayStage_basic (490.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	490.190s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayDeployment_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAPIGatewayDeployment_basic -timeout 120m
=== RUN   TestAccAWSAPIGatewayDeployment_basic
--- PASS: TestAccAWSAPIGatewayDeployment_basic (56.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	56.098s
...

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Sep 9, 2018
@bflad
Copy link
Contributor

bflad commented Sep 11, 2018

Can you please create a separate PR for the aws_api_gateway_deployment resource? Due to the API Gateway service implementation, we might not want to change that resource's read functionality in this manner. The aws_api_gateway_stage resource is a much easier change to get in. Thanks!

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. waiting-response Maintainers are waiting on response from community or contributor. labels Sep 11, 2018
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 12, 2018
@saravanan30erd
Copy link
Contributor Author

@bflad I ll create another PR for aws_api_gateway_deployment, I reverted the aws_api_gateway_deployment changes here.

@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 13, 2018
@bflad bflad added this to the v1.36.0 milestone Sep 13, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @saravanan30erd! 🚀 I'll ensure the new argument gets added to the documentation on merge.

--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings (193.87s)
--- PASS: TestAccAWSAPIGatewayStage_basic (362.61s)

@bflad bflad merged commit cbf057f into hashicorp:master Sep 13, 2018
bflad added a commit that referenced this pull request Sep 13, 2018
@bflad
Copy link
Contributor

bflad commented Sep 13, 2018

This has been released in version 1.36.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Gateway X-Ray Configuration
2 participants