Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Batching to Modifying Systems Manager Documents to Work Around Limits #6735

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

brandonstevens
Copy link
Contributor

Fixes #5328

Changes proposed in this pull request:

  • Add Batching to Modifying Systems Manager Documents to Work Around Limits

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMDocument_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSSMDocument_* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSSSMDocument_basic
=== PAUSE TestAccAWSSSMDocument_basic
=== RUN   TestAccAWSSSMDocument_update
=== PAUSE TestAccAWSSSMDocument_update
=== RUN   TestAccAWSSSMDocument_permission_public
=== PAUSE TestAccAWSSSMDocument_permission_public
=== RUN   TestAccAWSSSMDocument_permission_private
=== PAUSE TestAccAWSSSMDocument_permission_private
=== RUN   TestAccAWSSSMDocument_permission_batching
=== PAUSE TestAccAWSSSMDocument_permission_batching
=== RUN   TestAccAWSSSMDocument_permission_change
=== PAUSE TestAccAWSSSMDocument_permission_change
=== RUN   TestAccAWSSSMDocument_params
=== PAUSE TestAccAWSSSMDocument_params
=== RUN   TestAccAWSSSMDocument_automation
=== PAUSE TestAccAWSSSMDocument_automation
=== RUN   TestAccAWSSSMDocument_session
=== PAUSE TestAccAWSSSMDocument_session
=== RUN   TestAccAWSSSMDocument_DocumentFormat_YAML
=== PAUSE TestAccAWSSSMDocument_DocumentFormat_YAML
=== RUN   TestAccAWSSSMDocument_Tags
=== PAUSE TestAccAWSSSMDocument_Tags
=== CONT  TestAccAWSSSMDocument_basic
=== CONT  TestAccAWSSSMDocument_params
=== CONT  TestAccAWSSSMDocument_update
=== CONT  TestAccAWSSSMDocument_permission_private
=== CONT  TestAccAWSSSMDocument_permission_change
=== CONT  TestAccAWSSSMDocument_permission_public
=== CONT  TestAccAWSSSMDocument_permission_batching
=== CONT  TestAccAWSSSMDocument_DocumentFormat_YAML
=== CONT  TestAccAWSSSMDocument_session
=== CONT  TestAccAWSSSMDocument_automation
=== CONT  TestAccAWSSSMDocument_Tags
--- PASS: TestAccAWSSSMDocument_params (32.52s)
--- PASS: TestAccAWSSSMDocument_session (32.52s)
--- PASS: TestAccAWSSSMDocument_basic (33.96s)
--- PASS: TestAccAWSSSMDocument_permission_private (33.98s)
--- PASS: TestAccAWSSSMDocument_permission_batching (35.40s)
--- PASS: TestAccAWSSSMDocument_permission_public (43.07s)
--- PASS: TestAccAWSSSMDocument_automation (53.78s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (62.84s)
--- PASS: TestAccAWSSSMDocument_update (67.94s)
--- PASS: TestAccAWSSSMDocument_Tags (78.67s)
--- PASS: TestAccAWSSSMDocument_permission_change (78.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	78.696s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 5, 2018
@bflad bflad added the bug Addresses a defect in current functionality. label Dec 6, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @brandonstevens 🚀

--- PASS: TestAccAWSSSMDocument_basic (6.04s)
--- PASS: TestAccAWSSSMDocument_permission_batching (7.22s)
--- PASS: TestAccAWSSSMDocument_permission_public (9.53s)
--- PASS: TestAccAWSSSMDocument_update (13.06s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (14.28s)
--- PASS: TestAccAWSSSMDocument_params (14.50s)
--- PASS: TestAccAWSSSMDocument_session (17.31s)
--- PASS: TestAccAWSSSMDocument_permission_private (18.24s)
--- PASS: TestAccAWSSSMDocument_automation (21.32s)
--- PASS: TestAccAWSSSMDocument_permission_change (22.40s)
--- PASS: TestAccAWSSSMDocument_Tags (36.09s)

@bflad bflad added this to the v1.52.0 milestone Dec 7, 2018
@bflad bflad merged commit aeb8750 into hashicorp:master Dec 7, 2018
bflad added a commit that referenced this pull request Dec 7, 2018
@bflad
Copy link
Contributor

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_ssm_document: Unable to Share with more than 20 Accounts
2 participants