From 8c1a89e95ed61882c6144f76340a43a9da7a367e Mon Sep 17 00:00:00 2001
From: Tiago Katcipis <tiagokatcipis@gmail.com>
Date: Wed, 29 Dec 2021 21:48:28 +0100
Subject: [PATCH] fix: remove duplicated stack listing

---
 generate/generate.go | 16 +++-------------
 metadata.go          | 11 -----------
 2 files changed, 3 insertions(+), 24 deletions(-)

diff --git a/generate/generate.go b/generate/generate.go
index 2f4372ae3..6b98b9092 100644
--- a/generate/generate.go
+++ b/generate/generate.go
@@ -65,30 +65,20 @@ func Do(root string) error {
 		return fmt.Errorf("project's root %q is not a directory", root)
 	}
 
-	stackEntries, err := terramate.ListStacks(root)
-	if err != nil {
-		return fmt.Errorf("listing stack: %w", err)
-	}
-
 	metadata, err := terramate.LoadMetadata(root)
 	if err != nil {
-		return fmt.Errorf("loading metadata: %v", err)
+		return fmt.Errorf("loading metadata: %w", err)
 	}
 
 	var errs []error
 
-	for _, entry := range stackEntries {
+	for _, stackMetadata := range metadata.Stacks {
 		// At the time the most intuitive way was to start from the stack
 		// and go up until reaching the root, looking for a config.
 		// Basically navigating from the order of precedence, since
 		// more specific configuration overrides base configuration.
 		// Not the most optimized way (re-parsing), we can improve later
-		stackpath := project.AbsPath(root, entry.Stack.Dir)
-		stackMetadata, ok := metadata.StackMetadata(stackpath)
-		if !ok {
-			errs = append(errs, fmt.Errorf("stack %q: no metadata found", stackpath))
-			continue
-		}
+		stackpath := project.AbsPath(root, stackMetadata.Path)
 
 		globals, err := terramate.LoadStackGlobals(root, stackMetadata)
 		if err != nil {
diff --git a/metadata.go b/metadata.go
index 491d1be34..5d696f676 100644
--- a/metadata.go
+++ b/metadata.go
@@ -56,17 +56,6 @@ func LoadMetadata(basedir string) (Metadata, error) {
 	}, nil
 }
 
-// StackMetadata gets the metadata of a specific stack given its absolute path.
-func (m Metadata) StackMetadata(abspath string) (StackMetadata, bool) {
-	path := strings.TrimPrefix(abspath, m.basedir)
-	for _, stackMetadata := range m.Stacks {
-		if stackMetadata.Path == path {
-			return stackMetadata, true
-		}
-	}
-	return StackMetadata{}, false
-}
-
 // SetOnEvalCtx will add the proper namespace for evaluation of stack metadata
 // on the given evaluation context.
 func (m StackMetadata) SetOnEvalCtx(evalctx *eval.Context) error {