Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for checking that all D2 renders are up to date #1

Open
nhooyr opened this issue Oct 24, 2022 · 4 comments · Fixed by #22
Open

Add support for checking that all D2 renders are up to date #1

nhooyr opened this issue Oct 24, 2022 · 4 comments · Fixed by #22

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Oct 24, 2022

For every .d2 file, we should check that the corresponding .svg exists and is up to date.

@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 8, 2022

@alixander is it ok if I change d2-docs render.sh script to then instead copy all rendered .svgs to the generated directory? And not commit that directory.

@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 8, 2022

And why do all the svgs in there have .svg2 as the extension instead of .svg?

@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 8, 2022

This issue suggests we need something akin to tsconfig.json. Then d2 could just plop all your svgs in your desired folder.

And let you specify which layout you want to layout with. e.g for d2 diagrams in our monorepo, we'd want to test with TALA but in oss, dagre.

@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 24, 2023

Whoops, that PR only does formatting now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant