Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temp.sh: Not sure if things work right with the trap #19

Closed
nhooyr opened this issue Dec 8, 2022 · 1 comment · Fixed by #21
Closed

temp.sh: Not sure if things work right with the trap #19

nhooyr opened this issue Dec 8, 2022 · 1 comment · Fixed by #21

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Dec 8, 2022

Should probably review every single script use mktempd and fix them up and rethink it.
@nhooyr nhooyr mentioned this issue Dec 8, 2022
Open
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 8, 2022

Especially the traps in job.sh

nhooyr added a commit that referenced this issue Dec 8, 2022
@nhooyr
temp.sh: Fix interaction with exit traps
cb4d834 
Closes #19
@nhooyr nhooyr mentioned this issue Dec 8, 2022
Merged
nhooyr added a commit that referenced this issue Dec 8, 2022
@nhooyr
temp.sh: Fix interaction with exit traps
ef86359 
Closes #19
@nhooyr nhooyr closed this as completed in #21 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

temp.sh: Fix interaction with exit traps terrastruct/ci
1 participant
@nhooyr