feature: supports link on connections

[danielsuh05]

Connections now support link: (fixes issue #1827)

Some notes:

• Every single test file changed because all of the class names changed when adding link: "".
• Links don't work yet on connections in PDFs, not sure exactly how to do that.
• Check link-on-connections for the test I used.

[alixander]

I'm not sure what adding an empty <a> tag does. There's nothing for users to click and no indication it's clickable.

I was imagining something like this: link on the connection makes the label a hyperlink. So google here would be underlined and be in link-style blue (or purple if clicked). If there's a link and no label, the link becomes the label.

[danielsuh05]

Oh I see what you mean. I was trying to figure out how exactly you wanted it implemented so I decided to do this for now and get a review. I'll work on it

[danielsuh05]

Was this more what you were thinking?

[alixander]

Yup!

[alixander]

oh also i think it's a security issue if the edge label is a URL and the edge link is a URL and they are not the same URL. can you make that a compiler error and add a test for it please? (i'm pretty sure we do this for tooltips and links or something already)

[huyz]

Hi, what's the status on this PR?

[alixander]

Oops I did not realize the ball was in my court for reviewing. Sorry @danielsuh05 . I'm not sure if you've moved on. No worries if so I can take over, otherwise will leave a review ASAP

[huyz]

I hope to see this soon. Links on connections are pretty important. They open up a lot of possibilities for letting diagrams act as jump points to, e.g., code.

[danielsuh05]

I'm ok continuing with this issue.

[huyz]

Thank you @danielsuh05 and @alixander!

[alixander]

can you squash all the implementation commits into one and the test diffs into another? makes it easier to review to just see the diff for the implementation

---

the conflicts should just be a test rerun after rebasing master

[alixander]

@danielsuh05 Let me know if you'd like me to take over

[alixander]

i rebased and made minor fixes, thank you again @danielsuh05

[bo-ku-ra]

is the font color blue only?

[alixander]

yes, since that's the universal link color. But if you want it different, please make an issue