Fix duration 0 missing units #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 10b009c The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying terrazzo with
|
| Latest commit: |
10b009c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b7ebea94.terrazzo.pages.dev |
| Branch Preview URL: | https://fix-duration.terrazzo.pages.dev |
drwpow
commented
Nov 8, 2024
| @@ -0,0 +1,6 @@ | |||
| --- | |||
There was a problem hiding this comment.
stupid-seahorses-lie is the best name I have ever gotten
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Duration
0tokens should still have a unit according to the CSS spec. This was just a bad copy-and-paste from CSS dimensions, which are allowed to be unitless at0.Also bumps deps (and removes accidental monaco editor from the package lock)
How to Review