Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl Error for WaitError #629

Merged
merged 2 commits into from
May 12, 2024
Merged

feat: impl Error for WaitError #629

merged 2 commits into from
May 12, 2024

Conversation

DDtKey
Copy link
Collaborator

@DDtKey DDtKey commented May 11, 2024 •
edited
Loading

  • improves error/panic message
  • we're going to introduce fallible API gradually, so we can consider this as a first step
  • it solves the issue of unused fields, because debug impl is intentionally ignored by the dead_code lint

@DDtKey
style: drop temporary dead_code suppression
e141f64 
It was an issue with particular nightly version
@DDtKey DDtKey marked this pull request as ready for review May 12, 2024 13:25
@DDtKey
feat: impl Error for WaitError
14edf7c 
- we're going to gradually introduce fallible API, so we can consider this as a first step
- it solves the issue of unused fields, because debug impl is intentionally ignored by the dead_code lint
@DDtKey DDtKey changed the title style: drop temporary dead_code suppression feat: impl Error for WaitError May 12, 2024
@DDtKey DDtKey merged commit a42bdc9 into main May 12, 2024
9 checks passed
@DDtKey DDtKey deleted the style-drop-clippy-suppress branch May 12, 2024 13:56
@github-actions github-actions bot mentioned this pull request May 26, 2024
Merged
DDtKey pushed a commit that referenced this pull request May 26, 2024
@github-actions
chore: release v0.17.0 (#645)
03d534b 
## 🤖 New release
* `testcontainers`: 0.16.7 -> 0.17.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.17.0] - 2024-05-26

### Details
#### Bug Fixes
- Collect bridge IP address correctly
([#626](#626))
- Replace missed panics with `Result`
([#638](#638))

#### Features
- Impl `Error` for `WaitError`
([#629](#629))
- [❗] Extend `exec` interface to return logs and exec code
([#631](#631))
- Ability to access container logs
([#633](#633))
- [❗] Switch to fallible API
([#636](#636))
- Make container and exec logs `Send`able
([#637](#637))
- Map container not found error to `eof` for container log streams
([#639](#639))
- Expose follow flag for `stdout` and `stderr`
([#640](#640))
- Add ability to read container logs into `Vec`
([#641](#641))
- [❗] Add container startup timeout with default of 1 minute
([#643](#643))

#### Miscellaneous Tasks
- Fix clippy warning without features enabled
([#632](#632))

#### Refactor
- [❗] Drop re-export of `CgroupnsMode` accessible through `core`
([#630](#630))
- [❗] Drop previously deprecated `get_host_ip_address`
([#628](#628))
- [❗] Return `PortNotExposed` error from `ContainerState::host_port_*`
([#644](#644))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DDtKey