feat: add ability to read container logs into Vec
#641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have these methods for `exec`, they are good shortcuts, and I added them to `Container` as well to make the interfaces consistent.
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
DDtKey
pushed a commit
that referenced
this pull request
May 26, 2024
## 🤖 New release * `testcontainers`: 0.16.7 -> 0.17.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.17.0] - 2024-05-26 ### Details #### Bug Fixes - Collect bridge IP address correctly ([#626](#626)) - Replace missed panics with `Result` ([#638](#638)) #### Features - Impl `Error` for `WaitError` ([#629](#629)) - [❗] Extend `exec` interface to return logs and exec code ([#631](#631)) - Ability to access container logs ([#633](#633)) - [❗] Switch to fallible API ([#636](#636)) - Make container and exec logs `Send`able ([#637](#637)) - Map container not found error to `eof` for container log streams ([#639](#639)) - Expose follow flag for `stdout` and `stderr` ([#640](#640)) - Add ability to read container logs into `Vec` ([#641](#641)) - [❗] Add container startup timeout with default of 1 minute ([#643](#643)) #### Miscellaneous Tasks - Fix clippy warning without features enabled ([#632](#632)) #### Refactor - [❗] Drop re-export of `CgroupnsMode` accessible through `core` ([#630](#630)) - [❗] Drop previously deprecated `get_host_ip_address` ([#628](#628)) - [❗] Return `PortNotExposed` error from `ContainerState::host_port_*` ([#644](#644)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have these methods for
exec, they are good shortcuts, and I added them toContaineras well to make the interfaces consistent.