feat: expose configured bollard client #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows to access bollard client directly if needed. It's aligned with implementations of testcontainers for other languages. Definitely may be useful in some specific cases and allows to bypass some limitations. We could wrap and expose only particular API methods and hide the details from the user, but it's too much work and this way seems more pragmatic. Later we also can re-export bollard and bollard_stubs on demand (in order to simplify version managment of deps for users)
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
DDtKey
pushed a commit
that referenced
this pull request
Sep 26, 2024
## 🤖 New release * `testcontainers`: 0.23.0 -> 0.23.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.23.1] - 2024-09-26 ### Details #### Features - Expose configured bollard client ([#740](#740)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to access bollard client directly if needed. It's aligned with implementations of testcontainers for other languages. Definitely may be useful in some specific cases and allows to bypass some limitations. We could wrap and expose only particular API methods and hide the details from the user, but it's too much work and this way seems more pragmatic.
Later we also can re-export bollard and bollard_stubs on demand (in order to simplify version managment of deps for users)