TS Conversion > src/events.js
+ edit src/events.d.ts
#1008
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Conversion of
events.js
to TS per #494 . Also, changeevents.d.ts
to reflect what I perceive are more accurate types, and closer to those of the dom-testing-library docs.Why: 1.
events.ts
conversion motivation outlined in #494. 2.events.d.ts
changes might be unnecessary or innapropriate,How: 1. Changed filename. 2. Fixed errors. 3. Ran tests. 4. Repeat after necessary changes.
Checklist:
docs site NOT SURE IF RELEVANT
I don't think so, there's some things left in commits for this PR that are really better off changed or even removed, but warrant being present during code review.
I have some other comments that serve also as questions and as documentation, committed to the repo in their current form, but after responses to them, I think it's best I edit them to reflect any feedback. I've created them in Grok format as they are not necessarily inline comment-worthy, yet benefit from proximity to code, and their live/web viewable versions are at these links: