Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to Create React App #1292

Open
Mikilll94 opened this issue Aug 22, 2023 · 5 comments
Open

Remove all references to Create React App #1292

Mikilll94 opened this issue Aug 22, 2023 · 5 comments
Assignees

Comments

@Mikilll94
Copy link

Is your feature request related to a problem? Please describe.

We should remove all the references to Create React App. CRA is deprecated and no longer recommended in React docs.

Currently we have a reference to CRA here: https://testing-library.com/docs/react-testing-library/intro/

Describe the solution you'd like

Remove reference to CRA from here: https://testing-library.com/docs/react-testing-library/intro/

@MatanBobi
Copy link
Member

Hi @Mikilll94 :)
Even though CRA is not recommended anymore, most of our users are probably still using CRA as it's still the de-facto standard and since we're not the React core team, we don't need to push these changes yet as we're aiming to help our users. I think we can keep this one open but I wouldn't go ahead and push a fix just yet.

@nickserv
Copy link
Member

nickserv commented Sep 5, 2023

I disagree, I believe Vite is superior to Create React App, and because the React core team no longer recommends it for beginners we should follow.

@MatanBobi
Copy link
Member

I disagree, I believe Vite is superior to Create React App, and because the React core team no longer recommends it for beginners we should follow.

IMO there's a difference between removing every reference to just replacing it with create-vite-app. Either way, the references are minor and I have no strong feelings either way, so w/e you choose is fine by me.

@nickserv
Copy link
Member

nickserv commented Sep 5, 2023

I plan on replacing the note with a Vite template (possibly my own).

@nickserv nickserv self-assigned this Sep 5, 2023
@alexkrolick
Copy link
Collaborator

Moving the note about it being preinstalled in some situations to the install/setup section might be helpful, given the usage of react-scripts is still pretty high

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants