-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Storybook as Framework #937
Comments
Cool, nice to see it. Is this a framework type of integration (which has its own package), or more of a pattern like the ones for Redux and React Router (under the Examples page, with additional documentation maintained in the main package docs)? |
Nice to see you too, @alexkrolick! And thank you for the reply. We're working out the integration piece right now. My understanding is that it will be published soon as Beyond that, the rest would document how Storybook provides a GUI-like experience atop Testing Library. |
Most of the other libs are in the For the docs, we can check out the content in a PR and decide if it should be an Example or a Framework page. |
Thank you for the insights, Alex! It's awesome to here that you would consider maintaining the Because it's a relatively new integration, I suspect that there might be a decent amount churn (at least early on). So we'd like to come up with a strategy that doesn't overwhelm your team right off the bat. Mind if I loop in some of the Chromatic engineers to iron out the details on distribution and maintenance? |
With regard to documentation, I'll dive into the other Testing Library Framework docs and feel for the voice and patterns. As we get closer to release, I'll post some proposals here. Thank you! |
What we have done in the past is bring in the packages and then create a sub team for maintaining that framework, so we would just do that for any Chromatic people contributing to it |
Thank you for the clarification, that sounds great. I ran the idea of having having the integration live under the Testing Library org and learned a few things… Sounds like could work on our end. The bulk integration comes would come from I took a peak at the proposed library and it appears to do 3 things:
The biggest need on our side would be to update the |
Feel free to reach out if you need any help with documentation or any integration @chantastic |
thanks @MatanBobi! will do |
Hey maintainers!
I'd like to contribute Storybook documentation as a Framework .
With the introduction of Storybook Component Format 3, Storybook is doubling down on [Testing Library].
testing-library/dom
is the first-class way to write Storybook tests that interact with rendered components.Would you accept this documentation if I create a PR that mimics similar framework implementations like
TestCafe
,Puppeteer
, andCypress
?Thanks for considering this and for providing any feedback that would help me.
Michael
The text was updated successfully, but these errors were encountered: