Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tab): exclude hidden descendants #579

Merged
merged 4 commits into from
Mar 9, 2021
Merged

fix(tab): exclude hidden descendants #579

merged 4 commits into from
Mar 9, 2021

Commits on Feb 11, 2021

  1. Don't allow tabbing to elements inside hidden parents

    Ben Styles committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    462a5a8 View commit details
    Browse the repository at this point in the history

  2. fix: use isVisible helper to exclude hidden elements 

    Hidden elements should be excluded from tab order.
Hidden attribute can be overwritten by stylesheets.

There is a bug in jsdom that has to be resolved first.
See jsdom/jsdom#3111
    @ph-fritsche
    ph-fritsche committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    ee8921d View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Merge branch 'master' into pr-556

    @ph-fritsche
    ph-fritsche authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    9007972 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr-556

    @ph-fritsche
    ph-fritsche authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    bf73430 View commit details
    Browse the repository at this point in the history