Removes utility code formerly used by Docker #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a lot of redudant code that was deleted with the extension subcommand. However, code analysis failed to notice other parts that are only referenced in their own tests. This completes removal of the extra code made for the extension experiment. Fixes #172 #173 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
dead-code
branch
from
5378ad8 to
a52aa00
Compare
| @@ -106,15 +105,10 @@ func handleFlagOverrides(o *globals.GlobalOpts, homeDirFlag, manifestURLFlag str | |||
| func Execute(cmd *cobra.Command) error { | |||
| actualCmd, err := cmd.ExecuteC() | |||
| if actualCmd != nil && err != nil { // both are always true on error | |||
| var serr exec.ShutdownError | |||
There was a problem hiding this comment.
only dead code used this type
| @@ -95,11 +94,8 @@ func InitializeRunOpts(o *globals.GlobalOpts, reference string) error { | |||
| // This is exposed for re-use in "getenvoy extension run" | |||
| func Run(o *globals.GlobalOpts, cmd *cobra.Command, args []string) error { | |||
| r := envoy.NewRuntime(&o.RunOpts) | |||
| r.IO = ioutil.StdStreams{ | |||
| In: cmd.InOrStdin(), | |||
There was a problem hiding this comment.
in was never used
mathetake
approved these changes
May 11, 2021
added 2 commits
May 11, 2021 16:12
Signed-off-by: Adrian Cole <adrian@tetrate.io>
Signed-off-by: Adrian Cole <adrian@tetrate.io>
|
thanks for all the help with review today @mathetake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a lot of redundant code that was deleted with the extension
subcommand. However, code analysis failed to notice other parts that are
only referenced in their own tests. This completes removal of the extra
code made for the extension experiment.
Fixes #172 #173