Fix illegal instruction crash on some ARM systems #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tevador Can you merge this? |
hyc
reviewed
Apr 12, 2021
| @@ -95,6 +95,10 @@ JitCompilerA64::JitCompilerA64() | |||
| { | |||
| memset(reg_changed_offset, 0, sizeof(reg_changed_offset)); | |||
| memcpy(code, (void*) randomx_program_aarch64, CodeSize); | |||
|
|
|||
| #ifdef __GNUC__ | |||
There was a problem hiding this comment.
Is this really gcc-specific? The Android SDK uses clang, will this work there, or is some other fix needed for an Android build?
There was a problem hiding this comment.
It's a GCC-specific builtin, but clang supports it and even defines __GNUC__. Also, the same #ifdef is used in other places here.
|
Hello, This code was added and compiled but still mining crashs on smarphones. If JIT is disabled mining works but without JIT there is no serius mining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See xmrig/xmrig#1916