Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread codec 406 is not registered in the multicodec registry #456

Open
sbiaudet opened this issue Oct 25, 2020 · 3 comments
Open

Thread codec 406 is not registered in the multicodec registry #456

sbiaudet opened this issue Oct 25, 2020 · 3 comments

Comments

@sbiaudet
Copy link

I've seen that your codec 406 is not registered in this files https://github.com/multiformats/multicodec/blob/master/table.csv

We can have a conflict if an other project use to 406 code.
@carsonfarmer
Copy link
Member

carsonfarmer commented Oct 28, 2020 •
edited
Loading

Good point! It should probably be:

name,                           tag,            code,           description
...
thread,                         multiaddr,      0x0196,         Textile Thread
...

@sanderpick are you happy with that? I can fire off a PR likity-split on that one.

@sanderpick
Copy link
Member

Nice, SGTM

@carsonfarmer
Copy link
Member

multiformats/multicodec#201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sanderpick @carsonfarmer @sbiaudet