Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost records from the Subscribe() channel when records arrive concurrently #526

Open
merlinran opened this issue Jun 7, 2021 · 1 comment
Open

Lost records from the Subscribe() channel when records arrive concurrently #526

merlinran opened this issue Jun 7, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@merlinran
Copy link
Contributor

Reproducible by commit 66af150 . Run following and you'll see some record appears only 2 times, rather than expected 3.

GOTRACEBACK=all  testground run single --wait -p go-threads -t sync-threads -b exec:go -r local:exec -i 2 -tp records=10 -tp verbose=2 | grep "record #" | cut -d ":" -f 4- | sort | uniq -c | sort -r

It doesn't seem to relate to #525 .
@merlinran merlinran added the bug Something isn't working label Jun 7, 2021
@merlinran
Copy link
Contributor Author

merlinran commented Jun 7, 2021 •
edited
Loading

Note that the logic has changed a bit from the original implementation to surface the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@merlinran