From ddc6ea52d930c7792603fe5d93ef6e152bd6be90 Mon Sep 17 00:00:00 2001 From: Thang Tran Date: Tue, 24 Dec 2019 07:24:00 +0100 Subject: [PATCH] test: changed the buffer offset to avoid problem with the new behaviour of new V8 BackingStore API. By changing the offset, the base address of each test case will be different. Fixes: https://github.com/nodejs/node/issues/31061 --- test/addons/buffer-free-callback/test.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/test/addons/buffer-free-callback/test.js b/test/addons/buffer-free-callback/test.js index d25130a905ac90..70f1bead5b6c6a 100644 --- a/test/addons/buffer-free-callback/test.js +++ b/test/addons/buffer-free-callback/test.js @@ -16,20 +16,24 @@ function check(size, alignment, offset) { global.gc(); } +// NOTE: If adding more check() test cases, +// be sure to not duplicate alignment/offset. +// Refs: https://github.com/nodejs/node/issues/31061#issuecomment-568612283 + check(64, 1, 0); // Buffers can have weird sizes. -check(97, 1, 0); +check(97, 1, 1); // Buffers can be unaligned check(64, 8, 0); check(64, 16, 0); check(64, 8, 1); check(64, 16, 1); -check(97, 8, 1); -check(97, 16, 1); check(97, 8, 3); check(97, 16, 3); +check(97, 8, 5); +check(97, 16, 5); // Empty ArrayBuffer does not allocate data, worth checking -check(0, 1, 0); +check(0, 1, 2);