compact: Move downsampling and compact to sub dirs to avoid removal of potentially mounted dir. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f potentially mounted dir. Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
commented
Apr 9, 2018
| @@ -144,9 +150,12 @@ func runCompact( | |||
| } | |||
| done := true | |||
| for _, g := range groups { | |||
| os.RemoveAll(dataDir) | |||
There was a problem hiding this comment.
I am 100% sure this was erroring 100% time for me ):
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
fabxc
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this one is critical fix @fabxc
Before it, my removal of group dirs in local dir was simply not working (and err ignored), so I think I had all these compact overlaps because my compact planning was including ALL blocks (no matter what group O.o)
Signed-off-by: Bartek Plotka bwplotka@gmail.com