Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable YJIT for Ruby #7730

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

p8
Copy link
Contributor

@p8 p8 commented Sep 5, 2024

YJIT should improve Ruby performance.

Rails 7.2 enables YJIT itself after initialization.
This makes sure code that only runs on initializing is not jitted.
So for Rails we set RUBY_YJIT_ENABLE to falsey.

@p8 p8 requested a review from waghanza as a code owner September 5, 2024 14:52
Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be set in ruby/config.yaml

Rails 7.2 enables YJIT itself after initialization.
This makes sure code that only runs on initializing is not jitted.
So for Rails we set RUBY_YJIT_ENABLE to falsey.
@p8
Copy link
Contributor Author

p8 commented Sep 5, 2024

I've enabled it for all ruby apps, and made an exception for Rails, which sets it itself for improved performance.

@p8
Copy link
Contributor Author

p8 commented Sep 6, 2024

@waghanza I've updated ruby/config.yaml.

@waghanza waghanza enabled auto-merge (squash) September 6, 2024 15:23
@waghanza waghanza merged commit 16637a0 into the-benchmarker:master Sep 6, 2024
15 checks passed
@p8 p8 deleted the ruby/enable-yjit branch September 6, 2024 15:38
@waghanza
Copy link
Collaborator

waghanza commented Sep 9, 2024

https://web-frameworks-benchmark.netlify.app/result 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants