Small changes

thecalcc · Dec 12, 2024 · 086d67f · 086d67f
1 parent 5abbdc9
commit 086d67f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/client/components/planning-editor-standalone/field-adapters/custom-vocabularies.ts b/client/components/planning-editor-standalone/field-adapters/custom-vocabularies.ts
@@ -1,10 +1,10 @@
 import {IDropdownConfigVocabulary, IAuthoringFieldV2, ISubject, IVocabularyItem} from 'superdesk-api';
 import {superdeskApi} from '../../../superdeskApi';
 import {IFieldDefinition} from '../profile';
-import {getProfileFieldsConverted} from '../profile-converter';
+import {getPlanningProfileFields} from '../profile-fields';
 
 export const getCustomVocabularyFields = () => {
-    const customVocabularyIds = getProfileFieldsConverted()
+    const customVocabularyIds = getPlanningProfileFields()
         .filter((x) => x.type === 'custom_vocabulary')
         .map(({vocabularyId}) => vocabularyId);
     const result: Array<IFieldDefinition> = [];
@@ -37,7 +37,7 @@ export const getCustomVocabularyFields = () => {
                 storageAdapter: {
                     storeValue: (item, operationalValue: IVocabularyItem['qcode']) => {
                         const vocabulary = allVocabularies.get(id);
-                        const vocabItems = vocabulary.items.filter((x) => operationalValue?.includes(x.qcode)) ?? [];
+                        const vocabItems = vocabulary.items.filter((x) => operationalValue.includes(x.qcode)) ?? [];
 
                         // Subfield values
                         const itemsToSubject: Array<ISubject> = vocabItems.map((x) => ({

diff --git a/...ng-editor-standalone/profile-converter.ts → ...nning-editor-standalone/profile-fields.ts b/...ng-editor-standalone/profile-converter.ts → ...nning-editor-standalone/profile-fields.ts
@@ -14,7 +14,10 @@ interface ICustomVocabularyField extends IBaseField<'custom_vocabulary'> {
 
 type IFieldConverted = IBaseField<'normal'> | ICustomVocabularyField;
 
-export const getProfileFieldsConverted = (): Array<IFieldConverted> => {
+/**
+ * A function that handles planning profile field types so they can be used in authoring react.
+ */
+export const getPlanningProfileFields = (): Array<IFieldConverted> => {
     const planningProfile = planningApi.contentProfiles.get('planning');
     const planningGroups = getEditorFormGroupsFromProfile(planningProfile);
     const planningFieldIds = Object.values(planningGroups).flatMap((x) => x.fields);

diff --git a/client/components/planning-editor-standalone/profile.ts b/client/components/planning-editor-standalone/profile.ts
@@ -14,7 +14,7 @@ import {
     IAttachmentsFieldConfig,
 } from '../../planning-extension/src/authoring-react-fields/planning-attachments/interfaces';
 import {getCustomVocabularyFields} from './field-adapters/custom-vocabularies';
-import {getProfileFieldsConverted} from './profile-converter';
+import {getPlanningProfileFields} from './profile-fields';
 import {IEventOrPlanningItem} from 'interfaces';
 
 function getTextFieldConfig(options: {id: string; label: string, required: boolean}): IAuthoringFieldV2 {
@@ -190,7 +190,7 @@ export function getFieldDefinitions(): IFieldDefinitions {
 }
 
 export function getProfile() {
-    const planningFieldIds = getProfileFieldsConverted();
+    const planningFieldIds = getPlanningProfileFields();
     const skipped = new Set<string>();
     const fieldDefinitions = getFieldDefinitions();
     const profileV2: IContentProfileV2 = {