-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9395 Set up basic Jest/Enzyme tests for React #577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool! Just one question about the babelrc thing. Thanks for teaching me about this stuff!
@smoyth I think tests are failing now because some test suite isn't setting a NODE_ENV (or it's something other than Can you point me to the command that runs the test that gave this output on CI: ------------ BROWSER LOGS -------------
SEVERE 2019-02-15 17:48:45 +0000: http://127.0.0.1:44746/packs-test/application-d44347d2ad8823ff9d55.js 23362:16 Error: Module build failed: SyntaxError: Unexpected token (20:6)
18 | const displayIfOptions = ["always", "all_met", "any_met"];
19 | return displayIfOptions.map((option) => (
> 20 | <option
| ^ |
'development' is used by default unless BABEL_ENV or NODE_ENV are set. https://new.babeljs.io/docs/en/next/babelrc.html#env-environment-option
d0fd577
to
ca2604b
Compare
Closed in favor of #581
Fairly simple change overall, but you can read commit-by-commit if you want to see the process.