Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use less httpbin/google in tests #37

Merged
merged 5 commits into from
Sep 16, 2017
Merged

use less httpbin/google in tests #37

merged 5 commits into from
Sep 16, 2017

Conversation

raylu
Copy link
Contributor

@raylu raylu commented Sep 16, 2017 •
edited
Loading

raylu@1161b97 is a pretty complex replacement for #34, but it also tests a much smaller unit of the code

with this, there are just 3 tests that reach out to the internet

also,

  • turn on the pip cache in travis
  • rename request.py to request_object.py

@raylu raylu mentioned this pull request Sep 16, 2017
Open
@theelous3 theelous3 merged commit 2f89f78 into theelous3:master Sep 16, 2017
@theelous3 theelous3 mentioned this pull request Nov 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raylu @theelous3