Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ForemanApi from apypie #1789

Merged
merged 1 commit into from
Nov 26, 2024
Merged

use ForemanApi from apypie #1789

merged 1 commit into from
Nov 26, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Oct 28, 2024 •
edited
Loading

includes #1797

@evgeni evgeni force-pushed the the-refactoring branch 9 times, most recently from 4e78098 to 9a2b637 Compare October 28, 2024 11:49
@evgeni evgeni mentioned this pull request Oct 28, 2024
Merged
@evgeni evgeni force-pushed the the-refactoring branch 2 times, most recently from 3dd17c4 to ef6595f Compare October 28, 2024 12:44
ekohl
ekohl reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this some of the notes I made while reading this. I realize it's very much a work in progress and should result in a real PR to apypie itself before updating the vendored copy.

plugins/module_utils/_apypie.py Outdated Show resolved Hide resolved
plugins/module_utils/foreman_helper.py Show resolved Hide resolved
plugins/module_utils/_apypie.py Outdated Show resolved Hide resolved
plugins/module_utils/foreman_helper.py Outdated Show resolved Hide resolved
@evgeni evgeni force-pushed the the-refactoring branch 4 times, most recently from 8121f36 to 9adb24b Compare October 30, 2024 09:27
@evgeni evgeni force-pushed the the-refactoring branch 4 times, most recently from 6dee41e to 94c0813 Compare November 21, 2024 09:19
@evgeni evgeni changed the title move some ansible-free code to apypie use ForemanApi from apypie Nov 21, 2024
@evgeni evgeni marked this pull request as ready for review November 22, 2024 08:25
@evgeni evgeni merged commit 879ec33 into develop Nov 26, 2024
53 checks passed
@evgeni evgeni deleted the the-refactoring branch November 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeni @ekohl